Opened 9 years ago

Closed 8 years ago

Last modified 7 years ago

#2215 closed defect (implemented)

Man page should explain log domains; log domains should be usable

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There is an entire feature that we forgot to ever document. Log domains! We should add an entry to the manpage to explain them.

If somebody wants to take this on, you can see the syntax for log domains+severities in the doxygen comment for parse_log_severity_config(). The list of recognized domains is in domains_list in log.c

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

Added the manpage (and some more useful stuff for log domains) in a branch log_domains in my public repository.

comment:2 in reply to:  1 Changed 8 years ago by rransom

Replying to nickm:

Added the manpage (and some more useful stuff for log domains) in a branch log_domains in my public repository.

Looks good, except for a (theoretically) possible buffer overflow if format_msg is given a stupidly small buffer. See log_domains ( ssh://mob@repo.or.cz/srv/git/tor/rransom.git log_domains ) for a slightly ugly fix.

comment:3 Changed 8 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed
Summary: Man page should explain log domainsMan page should explain log domains; log domains should be usable

Slightly ugly, and probably not needed atm given how big the buffer is now, but it's worth going the long way around the block to avoid an overflow. Applied your fix, plus a pedantic-C fixup, and merged. Thanks!

comment:4 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:5 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.