Opened 18 months ago

Closed 17 months ago

Last modified 15 months ago

#22165 closed enhancement (fixed)

Rip out the option to collect local IP addresses

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, tbb-7.0-must, TorBrowserTeam201705R, tbb-fingerprinting
Cc: mcs, brade, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The NetworkInfoService (./netwerk/base/NetworkInfoServiceCocoa.cpp and ./netwerk/base/NetworkInfoServiceLinux.cpp) both collect a list of local IP addresses for use in nsNetworkInfoService::ListNetworkAddresses(). This is used by mDNS and the Presentation API. We should rip out the relevant part as a defense in depth

Child Tickets

Change History (6)

comment:1 Changed 18 months ago by gk

Actually, there is a Windows version, NetworkInfoServiceWindows.cpp, as well. We should probably return early in all three DoListAddresses() methods with NS_ERROR_FAILURE.

comment:2 Changed 17 months ago by arthuredelstein

Keywords: TorBrowserTeam201705R added
Status: newneeds_review

comment:3 Changed 17 months ago by gk

Cc: mcs brade added

Looks good to me. mcs/brade what do you think?

comment:4 in reply to:  3 Changed 17 months ago by mcs

Replying to gk:

Looks good to me. mcs/brade what do you think?

Yes, the patch looks good.

comment:5 Changed 17 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, this is commit 2c50abdbdd215f7a84211ce70d8c75a0a6f97187 on tor-browser-52.1.0esr-7.0-2.

comment:6 Changed 15 months ago by arthuredelstein

Cc: arthuredelstein added
Keywords: tbb-fingerprinting added
Note: See TracTickets for help on using tickets.