Opened 3 years ago

Closed 3 years ago

#22172 closed defect (worksforme)

prop140: What to do when a diff fails to apply?

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor4


Right now, we treat failures to apply a consensus diff as if the consensus download had failed. Is this what we should be doing?

(Formerly part of #22148)

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 3 years ago by nickm

I think we can treat a non-applying diff as if we had downloaded a bogus consensus. Rationale: we provided the source SHA3 digest that the diff is supposed to apply to; if it doesn't apply, then the cache is deeply confused, or we are.

comment:3 Changed 3 years ago by nickm

Status: acceptedneeds_information

Putting this into needs_information. I want to keep an eye on this as we try it in practice, but I think that the current approach will likely turn out to be okay.

comment:4 Changed 3 years ago by nickm

Parent ID: #13339

comment:5 Changed 3 years ago by nickm

Resolution: worksforme
Status: needs_informationclosed
Note: See TracTickets for help on using tickets.