Opened 3 years ago

Closed 3 years ago

#22183 closed defect (wontfix)

--disable-transparent option is gone without the ChangeLog record

Reported by: yurivict271 Owned by:
Priority: Medium Milestone:
Component: - Select a component Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It disappeared somewhere between 0.2.8.11 and 0.2.9.9.
The last mention of transparent proxy in ChangeLog was for 0.2.7.6.

ChangeLog should document all essential interface changes, both user-facing and build-facing.

The configured define USE_TRANSPARENT is still present in code, but it's initialization has changed in undocumented way.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by yurivict271

The de-facto new way of enabling of USE_TRANSPARENT is checking for both net/if.h and net/pfvar.h. This makes it always enabled even when not needed.

FYI, the FreeBSD port has a special option TRANSPARENT, off by default, that is rendered broken now.

Since transparent proxy is needed only by a small fraction of users, I suggest the behavior should be:

  1. there have to be --enable-transparent/--disable-transparent options
  2. --disable-transparent should be the default
  3. the above-mentioned headers should be checked only when the option is enabled

Also, checking net/pfvar.h is questionable since transparent proxy can be used with other than pf firewalls.

comment:2 Changed 3 years ago by cypherpunks

It got removed with #19449 in 0.2.9.1-alpha which is documented in the ChangeLog.

comment:3 Changed 3 years ago by yurivict271

Resolution: wontfix
Status: newclosed

Ok, thanks!

Note: See TracTickets for help on using tickets.