Changes between Initial Version and Version 1 of Ticket #22203


Ignore:
Timestamp:
May 9, 2017, 5:46:50 AM (2 years ago)
Author:
arma
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22203 – Description

    initial v1  
    2424I guess that means if we want to make do_hup reload the geoip stats file, the better (non-invasive) plan is to have a boolean want_to_reload_geoip{4,6} in geoip.c that we turn on in do_hup, and then we check the right boolean in geoip_is_loaded().
    2525
    26 I think there's a big argument for growing some good unit tests here, around "what happens when we reload this, collect those stats, reload that, examine those other stats, etc", so things are either subtly broken right now, or awfully fragile.
     26I think there's a big argument for growing some good unit tests here, around "what happens when we reload this, collect those stats, reload that, examine those other stats, etc", since things are either subtly broken right now, or awfully fragile.