Opened 3 years ago

Closed 3 years ago

#22211 closed defect (fixed)

mistaken comment in routerstatus_parse_entry_from_string()

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Trivial Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


  } else if (flav == FLAV_MICRODESC) {
    offset = -1; /* There is no identity digest */

I *think* it means to say "There is no descriptor digest" here -- since there is an identity digest in both kinds of consensus flavors.

(I am making a ticket, rather than just fixing it, so a second person can look at it and either agree or tell me why I'm mistaken.)

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by arma

Status: newneeds_review

comment:2 Changed 3 years ago by nickm

Milestone: Tor: 0.3.1.x-final

comment:3 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Sounds right to me; fixed in ee3ccd2facb2

Note: See TracTickets for help on using tickets.