Opened 2 years ago

Closed 2 years ago

#22216 closed enhancement (implemented)

Decide whether to sanitize padding-counts lines

Reported by: karsten Owned by: metrics-team
Priority: High Milestone: CollecTor 1.2.0
Component: Metrics/CollecTor Version:
Severity: Normal Keywords:
Cc: mikeperry, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I found this message in CollecTor's logs today:

2017-05-10 06:09:07,711 WARN o.t.c.b.SanitizedBridgesWriter:1212 Unrecognized line 'padding-counts 2017-05-10 01:48:43 (86400 s) bin-size=10000 write-drop=10000 write-pad=10000 write-total=10000 read-drop=10000 read-pad=10000 read-total=70000 enabled-read-pad=0 enabled-read-total=0 enabled-write-pad=0 enabled-write-total=0 max-chanpad-timers=0'. Skipping.

We need to decide whether it's okay to keep these lines in sanitized bridge descriptors, and if not, how to sanitize them. I believe it's okay to keep them, but I'd like to get confirmation on that.

Note that we should make this decision soon, because we're currently not sanitizing descriptors containing these lines. That means those bridges cannot be found in Atlas and won't be included in any statistics.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by iwakeh

Milestone: metrics-lib 1.7.0

As the related ticket #22217 this should be in the planning for 1.7.0

comment:2 Changed 2 years ago by karsten

Milestone: metrics-lib 1.7.0CollecTor 1.2.0

Ah, this is unrelated to metrics-lib. But I agree that we should do this really soon. Moving to the next CollecTor milestone.

comment:3 Changed 2 years ago by karsten

Status: newneeds_review

I believe we can just copy over these lines. Please find the last commit in my task-22216 branch.

comment:4 in reply to:  3 Changed 2 years ago by iwakeh

Status: needs_reviewmerge_ready

Replying to karsten:

I believe we can just copy over these lines. Please find the last commit in my task-22216 branch.

All looks fine, new test, all checks and tests pass.
Ready for merge.

comment:5 Changed 2 years ago by karsten

Resolution: implemented
Status: merge_readyclosed

Thanks for reviewing! Merged. Will deploy in a bit. Closing.

Note: See TracTickets for help on using tickets.