Opened 2 years ago

Closed 2 years ago

#22228 closed enhancement (implemented)

Deprecate setFailUnrecognizedDescriptorLines()

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone: metrics-lib 1.7.0
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We have two methods, DescriptorParser#setFailUnrecognizedDescriptorLines() and DescriptorReader#setFailUnrecognizedDescriptorLines() that a) are never used in known code and that b) can be easily replaced by checking whether Descriptor#getUnrecognizedLines() contains any lines.

We should get rid of those methods.

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by karsten

Status: newneeds_review

comment:2 Changed 2 years ago by iwakeh

Status: needs_reviewmerge_ready

Looks good.
Merge ready!

comment:3 Changed 2 years ago by karsten

Resolution: implemented
Status: merge_readyclosed

Great, thanks for looking! Tweaked a single word in the change log and pushed to master. Closing.

Note: See TracTickets for help on using tickets.