Selfrando embeds the RUNPATH in Linux binaries

checksec.sh is not happy with our RUNPATH. It seems selfrando is the culprit here:

0x000000000000001d (RUNPATH)            Library runpath: [/home/debian/install/selfrando]

added TorBrowserTeam201806R boklm201806 component::applications/tor browser owner::tbb-team parent::23073 priority::medium resolution::fixed severity::normal sponsor::4 status::closed tbb-rbm type::defect labels

Trac:
Parent: N/A to #23073 (moved)

Trac:
Sponsor: N/A to Sponsor4

Trac:
Cc: boklm to boklm, arlolra

As a workaround we could run chrpath -d on all elf binaries.

Replying to boklm:

As a workaround we could run chrpath -d on all elf binaries.

You mean after building a relevant component but before packaging it up? Works for me!

The commit 6063d5c6433a294176593a070138350cc723dbfa in branch bug_22242 is using chrpath -d to remove the RUNPATH from firefox binaries: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_22242&id=6063d5c6433a294176593a070138350cc723dbfa

Trac:
Status: new to needs_review
Keywords: N/A deleted, TorBrowserTeam201805R, tbb-rbm, boklm201805 added

Moving review tickets to June.

Trac:
Keywords: TorBrowserTeam201805R deleted, TorBrowserTeam201806R added

boklm201805 -> boklm201806

Trac:
Keywords: boklm201805 deleted, boklm201806 added

Looks good to me. I merged it to master with commit 2dfbef2eecb1ca19467b095b16c18f9c78d28445. Let's see in tomorrow's nightlies how this looks like.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #23800 (closed)

mentioned in issue #30449 (moved)

moved to tpo/applications/tor-browser#22242 (closed)

mentioned in issue tpo/applications/tor-browser#30449 (closed)