Opened 18 months ago

Closed 5 months ago

#22242 closed defect (fixed)

Selfrando embeds the RUNPATH in Linux binaries

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201806R, boklm201806
Cc: boklm, arlolra Actual Points:
Parent ID: #23073 Points:
Reviewer: Sponsor: Sponsor4

Description

checksec.sh is not happy with our RUNPATH. It seems selfrando is the culprit here:

0x000000000000001d (RUNPATH)            Library runpath: [/home/debian/install/selfrando]

Child Tickets

Change History (9)

comment:1 Changed 16 months ago by gk

Parent ID: #23073

comment:2 Changed 16 months ago by gk

Sponsor: Sponsor4

comment:3 Changed 13 months ago by arlolra

Cc: arlolra added

comment:4 Changed 6 months ago by boklm

As a workaround we could run chrpath -d on all elf binaries.

comment:5 in reply to:  4 Changed 6 months ago by gk

Replying to boklm:

As a workaround we could run chrpath -d on all elf binaries.

You mean after building a relevant component but before packaging it up? Works for me!

comment:6 Changed 6 months ago by boklm

Keywords: tbb-rbm TorBrowserTeam201805R boklm201805 added
Status: newneeds_review

The commit 6063d5c6433a294176593a070138350cc723dbfa in branch bug_22242 is using chrpath -d to remove the RUNPATH from firefox binaries:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_22242&id=6063d5c6433a294176593a070138350cc723dbfa

comment:7 Changed 5 months ago by gk

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201805R removed

Moving review tickets to June.

comment:8 Changed 5 months ago by boklm

Keywords: boklm201806 added; boklm201805 removed

boklm201805 -> boklm201806

comment:9 Changed 5 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. I merged it to master with commit 2dfbef2eecb1ca19467b095b16c18f9c78d28445. Let's see in tomorrow's nightlies how this looks like.

Note: See TracTickets for help on using tickets.