Opened 2 years ago

Closed 2 years ago

#22249 closed enhancement (implemented)

Remove deprecation warnings as soon as metrics-lib 1.7.0 is released

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Current Onionoo master does not use any deprecated metrics-lib methods, but as soon as we release metrics-lib 1.7.0 and update Onionoo to use that there will be some errors and some warnings. I found 2 errors and 3 warnings in the tests. There might be more when metrics-lib 1.7.0 comes out. This ticket is a placeholder to make sure that we remove these errors and warnings soon after they appear.

In this context we might also want to fix the deprecation warnings related to TimeFactory#getTime().

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by karsten

Status: newneeds_review

Please find a start in my branch task-22249, which however doesn't make all deprecation warnings disappear.

comment:2 in reply to:  1 Changed 2 years ago by iwakeh

Replying to karsten:

Please find a start in my branch task-22249, which however doesn't make all deprecation warnings disappear.

The branch looks fine and passes tests and checks.

In this context we might also want to fix the deprecation warnings related to TimeFactory#getTime().

While reviewing I came up with ideas for solving the above.
Please review this branch, which also makes it a little more obvious where ime is tweaked for testing. Now all compile warnings are gone.

comment:3 Changed 2 years ago by karsten

Resolution: implemented
Status: needs_reviewclosed

Cool! Merged. :) Thanks! Closing.

Note: See TracTickets for help on using tickets.