Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#22254 closed defect (fixed)

Our extensions get disabled in the Tor Browser 7.0a4 release candidate

Reported by: gk Owned by: tbb-team
Priority: Immediate Milestone:
Component: Applications/Tor Browser Version:
Severity: Blocker Keywords:
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Testing the release candidate for Tor Browser 7.0a4 on a 64bit Linux machine results in disabled extensions on start-up with

1494766438500	addons.xpi-utils	DEBUG	New add-on torbutton@torproject.org installed in app-profile
1494766438600	addons.xpi-utils	WARN	Disabling foreign installed add-on torbutton@torproject.org in app-profile
1494766438600	DeferredSave.extensions.json	DEBUG	Save changes
1494766438600	addons.xpi-utils	DEBUG	New add-on {73a6fe31-595d-460b-a920-fcc0f8843232} installed in app-profile
1494766438600	DeferredSave.extensions.json	DEBUG	Starting timer
1494766438700	addons.xpi-utils	WARN	Disabling foreign installed add-on {73a6fe31-595d-460b-a920-fcc0f8843232} in app-profile
1494766438700	DeferredSave.extensions.json	DEBUG	Save changes
1494766438700	addons.xpi-utils	DEBUG	New add-on https-everywhere-eff@eff.org installed in app-profile
1494766438700	DeferredSave.extensions.json	DEBUG	Starting write
1494766438700	DeferredSave.extensions.json	DEBUG	Write succeeded
1494766438700	addons.xpi-utils	DEBUG	XPI Database saved, setting schema version preference to 19
1494766438800	addons.xpi-utils	WARN	Disabling foreign installed add-on https-everywhere-eff@eff.org in app-profile
1494766438800	DeferredSave.extensions.json	DEBUG	Save changes
1494766438800	addons.xpi-utils	DEBUG	New add-on tor-launcher@torproject.org installed in app-profile
1494766438800	DeferredSave.extensions.json	DEBUG	Starting timer
1494766438800	addons.xpi-utils	WARN	Disabling foreign installed add-on tor-launcher@torproject.org in app-profile

This blocks the 7.0a4 release.

Child Tickets

Change History (4)

comment:1 Changed 2 years ago by gk

Using the 000-tor-browser.js file we shipped in 7.0a3 fixes the problem. Thus, one of the prefs we flipped since then is causing this.

comment:2 Changed 2 years ago by gk

Summary: Our extensions get disabled in the Tor Browser 7.0a4 releases candidateOur extensions get disabled in the Tor Browser 7.0a4 release candidate

comment:3 Changed 2 years ago by gk

Cc: mcs brade added
Resolution: fixed
Status: newclosed
+pref("gfx.font_rendering.graphite.enabled"; false);

is the culprit. pref() does not like a ; between pref name and value. Blah. This is fixed with commit 0d5ad00985cbeb4c1f06e328145a7863fd706851 on tor-browser-52.1.0esr-7.0-2 and commit 7bbd69956bd1a30051599a1dd4bf615bc40e55e8 on tor-browser-52.1.1esr-7.0-1.

comment:4 in reply to:  3 Changed 2 years ago by mcs

Replying to gk:

pref() does not like a ; between pref name and value. Blah.

Blah indeed. Apparently that was an easy typo to miss since at least three of us failed to notice it :(

Note: See TracTickets for help on using tickets.