check tests and parsing for duplicate keys and empty keys exceptions

This was discovered in #22217 (moved) in ExtraInfoDescriptorTest's padding-count tests (comments 6,7). Check other tests in ExtraInfoDescriptorTest and other test classes for similar issues and fix these

changed milestone to %metrics-lib 1.9.0

added component::metrics/library milestone::metrics-lib 1.9.0 owner::iwakeh priority::medium resolution::implemented severity::normal status::closed type::enhancement labels

Good candidate for 1.8.0.

Trac:
Milestone: N/A to metrics-lib 1.8.0

Trac:
Status: new to accepted
Owner: metrics-team to iwakeh

One day until the planned 1.8.0 release. Should we move this to 1.9.0, or is this already almost done?

Replying to karsten:

One day until the planned 1.8.0 release. Should we move this to 1.9.0, or is this already almost done?

This should go into 1.8.0; update following.

Replying to iwakeh:

Replying to karsten:

One day until the planned 1.8.0 release. Should we move this to 1.9.0, or is this already almost done?

> This should go into 1.8.0; update following.

OK, I checked and there are way too many expected-exception-tests to be changed for this release. It is important to have these. I'll check-in some changes later, but these might not need to go in now. So I'd suggest too to move this ticket to 1.9.0

Sounds good. Moving to 1.9.0.

Trac:
Milestone: metrics-lib 1.8.0 to metrics-lib 1.9.0

First batch of checking messages in expected exceptions is here.

There are 270 left:

src/test/java/org/torproject/descriptor/impl/RelayNetworkStatusConsensusImplTest.java:100
src/test/java/org/torproject/descriptor/impl/RelayNetworkStatusVoteImplTest.java:90
src/test/java/org/torproject/descriptor/impl/ServerDescriptorImplTest.java:80

And, of course the empty and duplicate key changes to tests.

Finally all exceptions in tests are verified (i.e., the exception's message). For all the other changes it seems that the introduction of "KeyValueMap" already completed the simplification of ParseHelper and duplication/empty key checking in #22279 (moved). The class 'KeyValueMap' has full coverage. Thus, this tasks seems to be finished.
Please review this branch.

Trac:
Status: accepted to needs_review

Great, thanks for going through all that test code! Squashed, rebased to master, added another commit for replacing remaining @Test() annotations with @Test, and pushed to master. Closing.

Trac:
Status: needs_review to closed
Resolution: N/A to implemented

closed