Opened 3 years ago

Closed 3 years ago

#22286 closed enhancement (implemented)

Add coverage markers to LZMA and Zstd compression backend

Reported by: ahf Owned by:
Priority: Low Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords:
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor: Sponsor4


The LZMA and Zstd compression backend lacks coverage markers in some paths. For example: where encoder/decoder initialisation fails.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by ahf

Actual Points: 0.1
Status: newneeds_review

Please review:

There's no feature changes in this branch - only LCOV markers, a minor whitespace fix, and a test addition.

comment:2 Changed 3 years ago by nickm

added a few comments on the LCOV_EXCL commit -- I think one or two of the exclusions might be erroneous, but maybe I'm wrong.

comment:3 Changed 3 years ago by nickm

Status: needs_reviewneeds_revision

comment:4 Changed 3 years ago by nickm

Resolution: implemented
Status: needs_revisionclosed

Reverted the parts I disagreed with and merged, so we can close this.

Note: See TracTickets for help on using tickets.