Opened 3 years ago

Closed 2 years ago

#22287 closed enhancement (fixed)

Switch from custom CollecTor downloader to metrics-lib's DescriptorCollector

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone: Onionoo-1.4.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I noticed the other day that Onionoo still parses CollecTor's Apache directory listings to download descriptors. We should switch to metrics-lib's DescriptorCollector which uses CollecTor's index.json for this purpose by default.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by karsten

Status: newneeds_review

Please review my branch task-22287.

comment:2 Changed 2 years ago by iwakeh

Milestone: Onionoo-1.3.0

comment:3 Changed 2 years ago by iwakeh

Milestone: Onionoo-1.3.0Onionoo-1.4.0

comment:4 Changed 2 years ago by iwakeh

Status: needs_reviewmerge_ready

Please find the rebased branch with two fixup commits.

The tests and checks on my task-22287 branch pass fine and Onionoo uses metrics-lib for retrieving descriptors.

Merge ready, but maybe give it another local test round.

comment:5 Changed 2 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Looks good, and good catch in that second fixup commit there. Successfully tested and pushed to master. Closing.

Note: See TracTickets for help on using tickets.