Opened 3 years ago

Closed 3 years ago

#22288 closed enhancement (fixed)

Use newly recognized OnionPerf keys

Reported by: karsten Owned by: metrics-team
Priority: High Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In metrics-lib 1.7.0 we added support for six new Torperf keys added by OnionPerf (#22122). Let's switch from the workaround that went through getUnrecognizedKeys() and use the new methods instead.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by karsten

Status: newneeds_review

Please review my branch task-22288.

comment:2 Changed 3 years ago by karsten

Priority: MediumHigh

Ugh, looks like we forgot this ticket, and after updating to a metrics-lib version that recognizes the new OnionPerf keys and hence does not include them in getUnrecognizedKeys() anymore, the onion server graph is all empty since mid-May. Raising priority to high.

comment:3 Changed 3 years ago by iwakeh

Status: needs_reviewmerge_ready

Changes build fine and look ok.
Merge-ready.

comment:4 Changed 3 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Thanks for looking! Rebased and pushed to master. Will deploy later today or tomorrow. Closing.

Note: See TracTickets for help on using tickets.