Opened 2 years ago

Closed 2 years ago

#22294 closed enhancement (fixed)

improve 'not recommended' tooltip text

Reported by: cypherpunks Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Possible new tooltip:

"Outdated tor version
This relay is running an old tor release with known issues.
"

discussion:
https://lists.torproject.org/pipermail/metrics-team/2017-April/000322.html

Child Tickets

Attachments (1)

0001-fixup-Improves-the-Not-recommended-tooltip-text.patch (3.4 KB) - added by cypherpunks 2 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 2 years ago by irl

Status: newneeds_review

comment:2 Changed 2 years ago by cypherpunks

Thanks for your fast reaction.

As said before I'd prefer "tor version" over "software version" because it is more specific.
With "software version" the operator might ask "What software is outdated? openssl? tor? something else?"

s/software version/tor version/g

comment:3 Changed 2 years ago by cypherpunks

less important:

Also:

that is not recommended by the directory authorities and may contain known issues.

Aren't the reasons to remove a version from the recommended versions list always a given problem with that version?

comment:4 in reply to:  3 Changed 2 years ago by irl

Replying to cypherpunks:

Aren't the reasons to remove a version from the recommended versions list always a given problem with that version?

I don't actually know. I suspect there are cases where there are no *known* issues, but there may be unknown issues and the version is not regularly tested anymore.

comment:5 Changed 2 years ago by cypherpunks

I'm fine with "may".

comment:6 in reply to:  1 Changed 2 years ago by cypherpunks

Replying to irl:

My proposed patch is here:

https://gitweb.torproject.org/user/irl/atlas.git/patch/?id=b2512498eff01d4a837c672134e3fad4a90cfe3f

Can someone that is not me review?

I agree with comment:2 that Tor version would be more specific especially because the label already uses Outdated Tor Version. However, I would change the label to Outdated Tor version (note the lower case version).

The bridge template should use This bridge instead of This relay in the tooltip. This is an previously existing typo but might as well fix it now. Also the search page should use bridge or relay in the tooltip when appropriate.

I'll attach a fixup patch once Onionoo stops being unstable and i can properly test my proposed changes.

Last edited 2 years ago by cypherpunks (previous) (diff)

comment:7 Changed 2 years ago by irl

Status: needs_reviewmerge_ready

Nice. (:

Will merge later today. Thanks.

comment:8 Changed 2 years ago by irl

Resolution: fixed
Status: merge_readyclosed

Merged.

Note: See TracTickets for help on using tickets.