Opened 6 months ago

Closed 6 months ago

#22298 closed defect (duplicate)

Linux update failed from 7.0a3 to 7.0a4 on Linux due to low disk space (with vague error)

Reported by: mikeperry Owned by: tbb-team
Priority: Low Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by mikeperry)

I had an update failure due to low disk space that had a cryptic error message. All I got was a popup that asked if another copy of Firefox was running.

The last-update.log doesn't seem to have a lot of information, but I am attaching it anyway.

Child Tickets

Attachments (1)

last-update.log (752.1 KB) - added by mikeperry 6 months ago.
last-update log from failure

Download all attachments as: .zip

Change History (5)

Changed 6 months ago by mikeperry

Attachment: last-update.log added

last-update log from failure

comment:1 Changed 6 months ago by mikeperry

Description: modified (diff)
Priority: MediumLow
Summary: Linux update failed from 7.0a3 to 7.0a4 on LinuxLinu update failed from 7.0a3 to 7.0a4 on Linux due to low disk space (with vague error)

I just realized that this was because I was out of disk space, causing this. Oddly, instead of a disk space error, I got a popup that said another copy of Firefox was running... Once I created enough free space, the update applied on the next Tor Browser restart.

Arguably this is an upstream bug. At least, we should not concern ourselves with it now.

comment:2 Changed 6 months ago by mikeperry

Summary: Linu update failed from 7.0a3 to 7.0a4 on Linux due to low disk space (with vague error)Linux update failed from 7.0a3 to 7.0a4 on Linux due to low disk space (with vague error)

comment:3 in reply to:  1 Changed 6 months ago by mcs

Replying to mikeperry:

I just realized that this was because I was out of disk space, causing this. Oddly, instead of a disk space error, I got a popup that said another copy of Firefox was running... Once I created enough free space, the update applied on the next Tor Browser restart.

Yes, error 70 from toolkit/mozapps/update/common/errors.h is WRITE_ERROR_EXTRACT. Looking at the code, the only place that is generated is in code that is trying to fwrite() while extracting a file from the MAR.

I am glad recovery happened once you freed up some space. Maybe we should create a patch that logs something a little better than "failed 70" though, such as "failed 70 (write error during file extraction)." But I bet Mozilla expects that an expert will need to look at a user's update log anyway to figure out what happened. But it still annoys me to have to go to a source file every time to look up a failure code.

Arguably this is an upstream bug. At least, we should not concern ourselves with it now.

I think there is already an upstream bug for this or a similar updater-out-of-space issue. I will look for it tomorrow.

comment:4 Changed 6 months ago by mcs

Resolution: duplicate
Status: newclosed

It looks like an error message string was added but code has not yet been written to use it:
https://bugzilla.mozilla.org/show_bug.cgi?id=315278#c36

We also have #18186, so I am closing this as a duplicate.

Note: See TracTickets for help on using tickets.