Opened 21 months ago
Last modified 10 months ago
#22312 new enhancement
Refactor/Simplify to clarify "we cache dir info" vs "we invite clients to use us as a directory guard"
Reported by: | arma | Owned by: | |
---|---|---|---|
Priority: | Medium | Milestone: | Tor: unspecified |
Component: | Core Tor/Tor | Version: | |
Severity: | Normal | Keywords: | 034-triage-20180328, 034-removed-20180328 |
Cc: | Actual Points: | ||
Parent ID: | #21676 | Points: | |
Reviewer: | Sponsor: |
Description
I was trying to work on #21676, and I got lost in a twisty little maze of "router_should_be_directory_server" and "dir_server_mode" and "decide_to_advertise_dir_impl" and "decide_to_advertise_begindir" and "directory_caches_dir_info" and "directory_permits_begindir_requests" and etc.
I think there are two main concepts here:
- (1) Do we want to fetch all the directory info that a directory mirror would fetch? (If we do, we should cache it, and we might as well serve it.)
- (2) Do we want to invite clients to use us as their directory mirror? (Whether clients actually do use us is up to whether the directory authorities tell them to.)
For (1), a lot of relays already do the fetching, e.g. so they can answer connection_or_digest_is_known_relay(), so maybe we are really close to declaring that the answer for any relay is yes. (See also Proposal 237, where we thought we did this step.) That would sure simplify things.
For (2), we're moving toward a world where only fallback mirrors and directory guards get asked these questions, so it's cheap to offer, since it's then up to the directory authorities to only take us up on it if they think we're a good fit.
Child Tickets
Change History (6)
comment:1 Changed 21 months ago by
Parent ID: | → #21676 |
---|
comment:2 Changed 17 months ago by
Milestone: | Tor: 0.3.2.x-final → Tor: 0.3.3.x-final |
---|
comment:3 Changed 13 months ago by
Milestone: | Tor: 0.3.3.x-final → Tor: 0.3.4.x-final |
---|
comment:4 Changed 11 months ago by
Keywords: | 034-triage-20180328 added |
---|
comment:5 Changed 11 months ago by
Keywords: | 034-removed-20180328 added |
---|
Per our triage process, these tickets are pending removal from 0.3.4.
comment:6 Changed 10 months ago by
Milestone: | Tor: 0.3.4.x-final → Tor: unspecified |
---|
These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.
Label a bunch of (arguable and definite) enhancements as enhancements for 0.3.4.