Opened 2 years ago

Closed 2 years ago

#22328 closed task (fixed)

Check if we can remove OSX clang PIE wrappers

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-gitian, TorBrowserTeam201706R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In the fix for #20439, we added clang wrappers to add the -fPIE flag, and avoid a build error when the -fPIE flag is explicitly set in the FLAGS.

After the switch to esr52, we should check if using those wrappers is still needed, or if they can be removed.

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by boklm

After removing the clang wrappers in rbm, and doing a test build, the binaries produced are still PIE. So it looks like the wrappers are no longer needed.

I have now started a build in gitian with the same changes to confirm.

comment:2 Changed 2 years ago by boklm

Keywords: TorBrowserTeam201706R added
Status: newneeds_review

I have been doing a nightly build with the following patch:
https://gitweb.torproject.org/user/boklm/tor-browser-bundle.git/commit/?h=bug_22328

And the binaries produced are still PIE.

comment:3 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Okay, nice. Applied to master and maint-7.0 (commit e8618a272b8ce8c8de834314b31a2fdd9259513a and 2b6992cf9aedafd4a121ff820aba182d0906c593).

Note: See TracTickets for help on using tickets.