Skip to content
Snippets Groups Projects
New look: Off

Save as... in the context menu results in using the catch-all circuit

    • Closed (moved) Issue created by Georg Koppen @gk

    Loading a website and then trying to download it via the "Save as..."-option in the context menu results in the catch-all circuit being used. This is new with the switch to ESR52.

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    • Georg Koppen added TorBrowserTeam201811R component::applications/tor browser ff52-esr owner::arthuredelstein priority::medium resolution::fixed severity::major status::closed tbb-7.0-frequent tbb-7.0-issues tbb-7.0-must tbb-linkability tbb-regression tbb-usability type::defect labels

      added TorBrowserTeam201811R component::applications/tor browser ff52-esr owner::arthuredelstein priority::medium resolution::fixed severity::major status::closed tbb-7.0-frequent tbb-7.0-issues tbb-7.0-must tbb-linkability tbb-regression tbb-usability type::defect labels

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Trac:
      Keywords: tb-7.0-must deleted, tbb-7.0-must added

    • A
      Arthur Edelstein @arthuredelstein ·

      I also see the catch-all circuit being used when I choose File > Save Page As.

    • A
      Arthur Edelstein @arthuredelstein ·

      Trac:
      Owner: tbb-team to arthuredelstein
      Status: new to assigned

    • Mark Smith
      Mark Smith @mcs ·

      Trac:
      Cc: N/A to brade, mcs

    • A
      Arthur Edelstein @arthuredelstein ·

      Here's a patch for review: https://github.com/arthuredelstein/tor-browser/commit/22343

      Trac:
      Keywords: TorBrowserTeam201705 deleted, TorBrowserTeam201706R added

    • A
      Arthur Edelstein @arthuredelstein ·

      Trac:
      Status: assigned to needs_review

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Loading torproject.org and doing a right-click and choosing "Save Page As..." gives me a ton of errors like:

      [06-07 13:02:38] Torbutton NOTE: tor domain isolator error: channel.loadInfo is null
loadInfo is null for channel https://www.torproject.org/images/military.jpg
Handler function threw an exception: TypeError: channel.loadInfo is null
Stack: NetworkMonitor.prototype._createNetworkEvent@re[/gre/modules/commonjs/toolkit/loader.js](/gre/modules/commonjs/toolkit/loader.js) -> re[/devtools/shared/webconsole/network-monitor.js:1077:9](/devtools/shared/webconsole/network-monitor.js:1077:9)
NetworkMonitor.prototype._onRequestHeader@re[/gre/modules/commonjs/toolkit/loader.js](/gre/modules/commonjs/toolkit/loader.js) -> re[/devtools/shared/webconsole/network-monitor.js:1154:5](/devtools/shared/webconsole/network-monitor.js:1154:5)
NetworkMonitor.prototype.observeActivity<@re[/gre/modules/commonjs/toolkit/loader.js](/gre/modules/commonjs/toolkit/loader.js) -> re[/devtools/shared/webconsole/network-monitor.js:1014:7](/devtools/shared/webconsole/network-monitor.js:1014:7)
exports.makeInfallible/<@re[/gre/modules/commonjs/toolkit/loader.js](/gre/modules/commonjs/toolkit/loader.js) -> re[/devtools/shared/ThreadSafeDevToolsUtils.js:101:14](/devtools/shared/ThreadSafeDevToolsUtils.js:101:14)
Line: 1077, column: 9

      and it does not download anything (while default 7.0 at least downloads the website) I built a custom build with the patch in comment:5 applied on top. But that was the only difference to our usual nightly builds.

      Trac:
      Status: needs_review to needs_revision
      Keywords: TorBrowserTeam201706R deleted, TorBrowserTeam201706 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Regression from 6.X.

      Trac:
      Keywords: N/A deleted, tbb-7.0-issues, tbb-regression added

    • A
      Arthur Edelstein @arthuredelstein ·

      Sorry for these errors. I think I have fixed this problem and made some other improvements. Here's a new version for review, rebased on top of the latest tor-browser 7.5 branch:

      ​https://github.com/arthuredelstein/tor-browser/commit/22343+1

      Trac:
      Keywords: TorBrowserTeam201706 deleted, TorBrowserTeam201706R added
      Status: needs_revision to needs_review

    • C
      cypherpunks @cypherpunks ·

      There's something broken with the "Save Link As..." contextual action, as well:

      • It, also, ends up over the catch-all circuit.
      • Furthermore, "sometimes" Tor Browser's custom "Save external file type?" dialog is not shown, instead Firefox's "Save As" dialog is shown directly. When this happens, after confirming said "Save As" dialog, the download is not started ("nothing happens", as they say). I have not yet discovered a reliable way of reproducing this but it's not rare, it occurs after trying a few times with random links.

      I have not (yet) seen these problems occur when following the link instead.

      Tor Browser 7.0, security level set to High.

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Replying to cypherpunks:

      There's something broken with the "Save Link As..." contextual action, as well:

      • It, also, ends up over the catch-all circuit.

      Yes. We might want to outsource that one to an own ticket as the external helper app dialog is involved and we had a bunch of trouble with that piece while transitioning to esr52. I created #22649 (moved).

      • Furthermore, "sometimes" Tor Browser's custom "Save external file type?" dialog is not shown, instead Firefox's "Save As" dialog is shown directly. When this happens, after confirming said "Save As" dialog, the download is not started ("nothing happens", as they say). I have not yet discovered a reliable way of reproducing this but it's not rare, it occurs after trying a few times with random links.

      #22616 (moved) might be of interest to you.

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Replying to arthuredelstein:

      Sorry for these errors. I think I have fixed this problem and made some other improvements. Here's a new version for review, rebased on top of the latest tor-browser 7.5 branch:

      ​https://github.com/arthuredelstein/tor-browser/commit/22343+1

      This breaks the Save Image As... option. Currently, that one is at least working even though the catch-all circuit is getting used. But with your patch I get

      Full message: TypeError: aInitiatingDocument is null
Full stack: continueSave@chrome://global/content/contentAreaUtils.js:467:1
internalSave/<@chrome://global/content/contentAreaUtils.js:446:7
Handler.prototype.process@re[/gre/modules/Promise.jsm](/gre/modules/Promise.jsm) -> re[/gre/modules/Promise-backend.js:932:23](/gre/modules/Promise-backend.js:932:23)
this.PromiseWalker.walkerLoop@re[/gre/modules/Promise.jsm](/gre/modules/Promise.jsm) -> re[/gre/modules/Promise-backend.js:813:7](/gre/modules/Promise-backend.js:813:7)
this.PromiseWalker.scheduleWalkerLoop/<@re[/gre/modules/Promise.jsm](/gre/modules/Promise.jsm) -> re[/gre/modules/Promise-backend.js:747:11](/gre/modules/Promise-backend.js:747:11)

      . I guess it might be worth addressing the catch-all-circuit-issue for the image saving part while we are at it.

      Trac:
      Keywords: TorBrowserTeam201706R deleted, TorBrowserTeam201706 added
      Status: needs_review to needs_revision

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Moving Tickets to July 2017.

      Trac:
      Keywords: TorBrowserTeam201706 deleted, TorBrowserTeam201707 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Tracking frequent 7.0 reports

      Trac:
      Keywords: N/A deleted, tbb-7.0-frequent added

    • A
      Arthur Edelstein @arthuredelstein ·

      Here's a new version that covers the Save As part. Please review :)

      https://github.com/arthuredelstein/tor-browser/commit/22343+4

      Trac:
      Keywords: TorBrowserTeam201707 deleted, TorBrowserTeam201707R added
      Status: needs_revision to needs_review

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      I still get exceptions:

      [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebBrowserPersist.savePrivacyAwareURI]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/contentAreaUtils.js :: internalPersist :: line 579"  data: no]  (unknown)

      STR:

      1. Open a locally stored PDF file
      2. Right-click on it and choose Save Page As...
      3. Choose location and press Save
      4. The download fails with the exception
      5. It seems even that the file gets corrupted/vanishes

      Trac:
      Status: needs_review to needs_revision
      Keywords: TorBrowserTeam201707R deleted, TorBrowserTeam201707 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      FWIW: This happens on Linux and with the patches for #22618 (moved) applied (although I think the later should not matter in this case).

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Moving our Tickets to August.

      Trac:
      Keywords: TorBrowserTeam201707 deleted, TorBrowserTeam201708 added

    • A
      Arthur Edelstein @arthuredelstein ·

      Replying to gk:

      I still get exceptions:

      Good catch!

      Here's a new version for review, with this issue fixed, and rebased to the latest TBB alpha branch: https://github.com/arthuredelstein/tor-browser/commit/22343+5

      Trac:
      Keywords: TorBrowserTeam201708 deleted, TorBrowserTeam201708R added
      Status: needs_revision to needs_review

    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply