Changes between Initial Version and Version 1 of Ticket #22343, comment 56


Ignore:
Timestamp:
Nov 12, 2018, 9:56:56 AM (6 months ago)
Author:
gk
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22343, comment 56

    initial v1  
    3131in the patch. Why are we switching in the `onImage` case from `isPrivate` to `isContentWindowPrivate` but not in the former case (the latter `onVideo` or `orAudio` case already had that before)? If that's correct and not just an oversight, it might be worth commenting it.
    3232
    33 2) From looking at he code in `ContentClick.jsm` It seems we might be able to trigger `window.openLinkIn(json.href, where, params);` which could lead to false FPI in the `save` case (see the: `// Todo(903022): code for where == save`) or is that just a leftover comment and we are actually good?
     332) From looking at the code in `ContentClick.jsm` It seems we might be able to trigger `window.openLinkIn(json.href, where, params);` which could lead to false FPI in the `save` case (see the: `// Todo(903022): code for where == save`) or is that just a leftover comment and we are actually good?
    3434
    35353) What about