Stop leaking routerinfos that are rejected due to keypinning

When we added the keypinning code to dirserv_add_descriptor, we forgot to free rejected routerinfos.

We should backport this to 0.2.9, because it is the earliest version run by the public directory authorities. (And it's LTS.)

changed milestone to %Tor: 0.3.1.x-final

added 029-backport 030-backport actualpoints::0.1 component::core tor/tor memory-leak milestone::Tor: 0.3.1.x-final points::0.1 priority::high resolution::fixed severity::major status::closed type::defect version::tor 0.2.7.2-alpha labels

Please see my branch bug22370-029 on github. Key pinning was turned on by default in 0.3.0.2-alpha. 3/8 directory authorities are running versions > 0.3.0.2-alpha.

Trac:
Priority: Medium to High
Status: new to needs_review
Severity: Normal to Major

Opened #22372 (moved) to try to make sure we don't do this again.

Looks like the cause of #21926 (moved) perhaps?

#22349 (moved) probably makes this way worse. :)

I made a bug22370-029-2 branch that fixes a typo in your commit message, removes a "tor-" from the changes file, and expands the function comment a bit. I'm afraid it's rebased since I don't know how to change commit messages otherwise. Do you like it?

Looks fine to me. Remember we want to backport this to 0.2.9 and later. But we don't have to do that right now.

Trac:
Status: needs_review to merge_ready

I have merged, to 0.2.9 and up.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

Replying to arma:

Looks like the cause of #21926 (moved) perhaps?

Yes! I think #21926 (moved) is resolved now.

closed

changed time estimate to 48m

added 48m of time spent

mentioned in issue #22371 (moved)

mentioned in issue #22372 (moved)

moved to tpo/core/tor#22370 (closed)

mentioned in issue tpo/core/tor#22372 (closed)