Opened 2 years ago

Closed 2 years ago

#22371 closed defect (wontfix)

Always send AUTHDIR_NEWDESC events in response to new descriptors

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version: Tor: 0.2.7.2-alpha
Severity: Normal Keywords: 030-backport-maybe, 029-backport-maybe, review-group-18
Cc: Actual Points: 0.2
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description

There are two cases where we don't send an AUTHDIR_NEWDESCS event:

  • when we reject a descriptor due to keypinning, and
  • when we drop a descriptor, but not due to cosmetic differences

This is a bug on tor-0.2.0.1-alpha and tor-0.2.7.2-alpha.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by teor

Please see my branch bug22371-029.
We might want to backport this to 0.2.9 because it's LTS, but for a rarely-used feature, I'm not sure.

Opened #22372 to try to make sure we don't do this again.

comment:2 Changed 2 years ago by teor

(Oh, that branch includes the memory leak fix from #22370, because they are next to each other.)

comment:3 Changed 2 years ago by arma

I don't object to fixing this one.

But see also #22377 for the now-competing proposal. :)

comment:4 Changed 2 years ago by nickm

Status: newneeds_review

comment:5 Changed 2 years ago by nickm

Keywords: review-group-18 added

comment:6 Changed 2 years ago by nickm

Resolution: wontfix
Status: needs_reviewclosed

Going to call this wontfix based on #22377 -- instead, we just kill off this event in 0.3.2.x.

Note: See TracTickets for help on using tickets.