Rip out AUTHDIR_NEWDESCS event?

[arma]

I vaguely remember that weasel added this feature back when the directory authorities were running the Naming scripts?

Now all of those scripts are gone.

I don't know of any directory authorities who run with their control port open now.

Maybe this is a great time to just get rid of it?

Motivated by the bug in #22371.

[arma]

(Maybe the test network, or chutney, would still enjoy having it though?)

[teor]

Replying to arma:

(Maybe the test network, or chutney, would still enjoy having it though?)

If I were testing relay descriptor checks in chutney, I'd want it.

[arma]

weasel confirms that he doesn't use it anymore.

So I think no dir auths on the main network have a control port open.

We could keep the feature if we think maintaining it for chutney etc is sufficiently useful.

[Sebastian]

I don't use it.

[nickm]

Damian, would anything go wrong if we deprecated this and/or just took it out?

[atagar]

Hi Nick. Nope, feel free to deprecate and/or remove. That said, I'd appreciate a note saying the tor version where it's gone (stem makes an effort to provide nice exception messages when an event doesn't exist due to your version).

[nickm]

Okay, let's do this in 0.3.2.x then. But if we decide not to, we should reopen and possibly merge #22371 .

[nickm]

See branch ticket22377 in my public Tor repository.

See also branch ticket22377_spec in my torspec repository.

[nickm]

Put 0.3.2 needs_review and merge_ready tickets into review-group-23.

[dgoulet]

Code lgtm;

About the spec patch, shouldn't we leave section 4.1.8. intact but mention at the beginning that it has been removed? I'm saying that because we have many supported version that still has it and removing it from our spec could lead to some confusion because "oh stem has that but I can't find it in the spec".

We kind of did that with "dir-usage" mentioning that we have removed it in 029.

Moving that in need info but if consensus is that it's fine, merge ready!

[nickm]

oh, good point. will make that change then merge.

[nickm]

changed, merged. Thanks!