Opened 4 months ago

Closed 12 days ago

#22377 closed enhancement (implemented)

Rip out AUTHDIR_NEWDESCS event?

Reported by: arma Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-23
Cc: atagar Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

I vaguely remember that weasel added this feature back when the directory authorities were running the Naming scripts?

Now all of those scripts are gone.

I don't know of any directory authorities who run with their control port open now.

Maybe this is a great time to just get rid of it?

Motivated by the bug in #22371.

Child Tickets

Change History (13)

comment:1 Changed 4 months ago by arma

(Maybe the test network, or chutney, would still enjoy having it though?)

comment:2 in reply to:  1 Changed 4 months ago by teor

Replying to arma:

(Maybe the test network, or chutney, would still enjoy having it though?)

If I were testing relay descriptor checks in chutney, I'd want it.

comment:3 Changed 4 months ago by arma

weasel confirms that he doesn't use it anymore.

So I think no dir auths on the main network have a control port open.

We could keep the feature if we think maintaining it for chutney etc is sufficiently useful.

comment:4 Changed 4 months ago by Sebastian

I don't use it.

comment:5 Changed 3 months ago by nickm

Cc: atagar added

Damian, would anything go wrong if we deprecated this and/or just took it out?

comment:6 Changed 3 months ago by atagar

Hi Nick. Nope, feel free to deprecate and/or remove. That said, I'd appreciate a note saying the tor version where it's gone (stem makes an effort to provide nice exception messages when an event doesn't exist due to your version).

comment:7 Changed 3 months ago by nickm

Okay, let's do this in 0.3.2.x then. But if we decide not to, we should reopen and possibly merge #22371 .

comment:8 Changed 4 weeks ago by nickm

Owner: set to nickm
Status: newaccepted

comment:9 Changed 4 weeks ago by nickm

Status: acceptedneeds_review

See branch ticket22377 in my public Tor repository.

See also branch ticket22377_spec in my torspec repository.

comment:10 Changed 13 days ago by nickm

Keywords: review-group-23 added

Put 0.3.2 needs_review and merge_ready tickets into review-group-23.

comment:11 Changed 13 days ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewneeds_information

Code lgtm;

About the spec patch, shouldn't we leave section 4.1.8. intact but mention at the beginning that it has been removed? I'm saying that because we have many supported version that still has it and removing it from our spec could lead to some confusion because "oh stem has that but I can't find it in the spec".

We kind of did that with "dir-usage" mentioning that we have removed it in 029.

Moving that in need info but if consensus is that it's fine, merge ready!

comment:12 Changed 12 days ago by nickm

oh, good point. will make that change then merge.

comment:13 Changed 12 days ago by nickm

Resolution: implemented
Status: needs_informationclosed

changed, merged. Thanks!

Note: See TracTickets for help on using tickets.