Opened 6 months ago

Closed 4 months ago

#22391 closed enhancement (invalid)

Add torrc.d configuration directory on deb packages

Reported by: Jigsaw52 Owned by: weasel
Priority: Medium Milestone:
Component: Internal Services/Service - deb.tpo Version: Tor: 0.3.1.1-alpha
Severity: Normal Keywords: deb torrc
Cc: iry@…, adrelanos Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A torrc.d style configuration directory could be added to the debian packages for version 0.3.1.1-alpha and above. Since #1922 is now implemented, it is easy to add this feature.

I attempted to add this feature on this branch: https://github.com/Jigsaw52/debian-tor/tree/add-torrc.d

Child Tickets

Change History (8)

comment:1 Changed 5 months ago by iry

Cc: iry@… added

comment:2 Changed 5 months ago by iry

Thank you for opening the ticket and work on the problem, Jigsaw52!

I have sent a feature request to Debain BTS:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866187

comment:3 Changed 5 months ago by adrelanos

Cc: adrelanos added

comment:4 Changed 5 months ago by iry

Although it has not been settled down on torrc.d will be implemented in Debian tor package, if it is the way as Jigsaw52's pull request, then there will be a potential problem:

  1. According to Jigsaw52's pull request, %include /etc/torrc.d will be added to /usr/share/tor/tor-service-defaults-torrc
  2. torrc files generated by users/applications go to /etc/torrc.d

Then if the user used an application to generate a torrc file with a proxy config, let's say. And after a while, the proxy setting is no longer needed/valid, there is no obvious way to find previous settings. As a normal user, he/she may examine /etc/tor/torrc, but there will be no proxy settings, which may cause a confusing and frustrating debugging process.

Therefore, Patrick proposed the following solution(http://phabricator.kkkkkkkkkk63ava6.onion/T699):

At the very top (?) of /etc/tor/torrc as per Debian's default should explain the .d folder set up by Debian (/usr/share/tor/tor-service-defaults-torrc`).

/etc/tor/torrc as per Debian's default should discourage users modification of /etc/tor/torrc?

And advice users to use /etc/torrc.d (or whatever folder(s) Debian will set up) since that won't throw dpkg interactive conflict resolution dialogs when /etc/tor/torrc gets modified by Debian?

Do you think it will be a good solution? I am looking forward to a further discussion since it is a really important feature for Debian and its derivatives.

Thank you very much!

comment:5 Changed 5 months ago by weasel

This is not the place to discuss bugs/improvements to the debian packaging of Tor. Please file them against the Debian package on the Debian BTS.

https://bugs.debian.org/
https://bugs.debian.org/tor
https://bugs.debian.org/866187

comment:6 Changed 5 months ago by weasel

Resolution: invalid
Status: newclosed

comment:7 Changed 4 months ago by Jigsaw52

Resolution: invalid
Status: closedreopened

I'm reopening because this issue was originally about the deb packages provided by tor on https://deb.torproject.org/.

Even if debian decides to implement this functionality on their packages, I still think it makes sense to add it to the tor packages too as they are the recommended way to install tor on some platforms.

comment:8 Changed 4 months ago by weasel

Resolution: invalid
Status: reopenedclosed

Nevertheless, the deb.tpo component is about the infrastructure of deb.tpo, not about the packages there. So this is first and foremost the wrong component.

Secondly, bugs against the debian packaging do belong on the Debian BTS.

Note: See TracTickets for help on using tickets.