Opened 3 years ago

Last modified 3 years ago

#22408 new defect

Refactor functions over 300 lines long.

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-triage-20180328, 034-removed-20180328
Cc: catalyst Actual Points: technical-debt refactor long-functions cthulhucode
Parent ID: #6313 Points: 5
Reviewer: Sponsor:


I think it's reasonable to impose a much smaller limit, but let's start by attacking the worst offenders. cc'ing catalyst because we've talked about this before.

It's probably a good idea to use a separate ticket or separate branch for each one.

300 connection_listener_new
306 networkstatus_set_current_consensus
327 rend_service_receive_introduction
330 ed_key_init_from_file
332 circuit_get_open_circ_or_launch
355 tor_spawn_background
360 router_dump_router_to_string
389 networkstatus_verify_bw_weights
389 parse_socks
399 connection_edge_process_relay_cell
404 circuit_expire_building
449 parse_port_config
535 options_act
541 connection_ap_handshake_rewrite_and_attach
548 router_parse_entry_from_string
638 networkstatus_parse_vote_from_string
973 networkstatus_compute_consensus
1269 options_validate

Child Tickets

#27662needs_revisionrefactor networkstatus_parse_vote_from_string()Core Tor/Tor

Change History (6)

comment:1 Changed 3 years ago by nickm

Component: - Select a componentCore Tor/Tor

comment:2 Changed 3 years ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

comment:3 Changed 3 years ago by dgoulet

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Moving a bunch of tickets from 033 to 034.

comment:4 Changed 3 years ago by nickm

Keywords: 034-triage-20180328 added

comment:5 Changed 3 years ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:6 Changed 3 years ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.