Opened 5 weeks ago

Closed 4 weeks ago

#22413 closed defect (fixed)

build fails with libzstd-0.5.1

Reported by: catalyst Owned by: catalyst
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version: Tor: 0.3.1.1-alpha
Severity: Normal Keywords: tbb-needs
Cc: gk, ahf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Ubuntu 16.04 (amd64 in my case) has libzstd-dev 0.5.1-1. It looks like master uses some libzstd symbols that are newer than that. See attached logs.

Child Tickets

Attachments (1)

buildlog (10.6 KB) - added by catalyst 5 weeks ago.

Download all attachments as: .zip

Change History (11)

Changed 5 weeks ago by catalyst

comment:1 Changed 4 weeks ago by gk

  • Cc gk added

comment:2 Changed 4 weeks ago by catalyst

Looking at the zstd history, it seems like ZSTD_CStream (which seems to be part of a streaming compression API that the consensus compression code uses) is new in zstd-1.1? Also ZSTD_VERSION_STRING looks like it is new in 0.6.1.

We should probably check for a minimum version (1.1?) at configure time.

This is probably relevant to deciding what new compression libraries to support for Tor Browser builds.

comment:3 Changed 4 weeks ago by nickm

  • Cc ahf added

comment:4 Changed 4 weeks ago by gk

FWIW: We build Tor Browser for Linux on Debian Wheezy (oldstable right now) to allow CentOS 6 users to have a Tor Browser as well (we already need to jump through some hoops for that to make that happen). Looking at the available package version it seems that it only got recently added to Debian. There is no zstd related package in Debian stable (or oldstable for that matter) right now. The upcoming stable (Stretch) has 1.1.2.

comment:5 Changed 4 weeks ago by teor

  • Keywords tbb-needs added
  • Version set to Tor: 0.3.1.1-alpha

comment:6 Changed 4 weeks ago by catalyst

  • Owner set to catalyst
  • Status changed from new to accepted

comment:7 Changed 4 weeks ago by catalyst

  • Status changed from accepted to needs_review

comment:8 Changed 4 weeks ago by nickm

lgtm but needs a changes file?

comment:9 Changed 4 weeks ago by catalyst

Thanks. Updated with a changes file.

comment:10 Changed 4 weeks ago by nickm

  • Resolution set to fixed
  • Status changed from needs_review to closed

Merged; thanks!

Note: See TracTickets for help on using tickets.