Format error in our pipeline patch

I was building tor-browser.git with --enable-debug and -Werror=format and it revealed a format error in our #5282 (closed) patch. The line is

      fprintf(stderr, "WTF-combine: Sent %lld/%lld bytes of %lld combined pipelined requests for host %s\n",
              alreadyPending+totalSent, totalAvailable, reqsSent, ci->Origin());

But the first three arguments after the format string are unsigned long integers, not long long integers.

added TorBrowserTeam201705R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed type::defect labels

Here's a patch for review: https://github.com/arthuredelstein/tor-browser/commit/22415

Trac:
Keywords: TorBrowserTeam201705 deleted, TorBrowserTeam201705R added
Status: new to needs_review

Trac:
Description: I was building tor-browser.git with -Werror=format and it revealed a format error in our #5282 (closed) patch. The line is

      fprintf(stderr, "WTF-combine: Sent %lld/%lld bytes of %lld combined pipelined requests for host %s\n",
              alreadyPending+totalSent, totalAvailable, reqsSent, ci->Origin());

But the first three arguments after the format string are unsigned long integers, not long long integers.

to

I was building tor-browser.git with --enabled-debug and -Werror=format and it revealed a format error in our #5282 (closed) patch. The line is

      fprintf(stderr, "WTF-combine: Sent %lld/%lld bytes of %lld combined pipelined requests for host %s\n",
              alreadyPending+totalSent, totalAvailable, reqsSent, ci->Origin());

But the first three arguments after the format string are unsigned long integers, not long long integers.

Trac:
Description: I was building tor-browser.git with --enabled-debug and -Werror=format and it revealed a format error in our #5282 (closed) patch. The line is

      fprintf(stderr, "WTF-combine: Sent %lld/%lld bytes of %lld combined pipelined requests for host %s\n",
              alreadyPending+totalSent, totalAvailable, reqsSent, ci->Origin());

But the first three arguments after the format string are unsigned long integers, not long long integers.

to

I was building tor-browser.git with --enable-debug and -Werror=format and it revealed a format error in our #5282 (closed) patch. The line is

      fprintf(stderr, "WTF-combine: Sent %lld/%lld bytes of %lld combined pipelined requests for host %s\n",
              alreadyPending+totalSent, totalAvailable, reqsSent, ci->Origin());

But the first three arguments after the format string are unsigned long integers, not long long integers.

NACK. Use PRIu64 from inttypes.h, your patch assumes LP64 and is broken on Windows, which uses LLP64.

Trac:
Status: needs_review to needs_revision

Replying to yawning:

NACK. Use PRIu64 from inttypes.h, your patch assumes LP64 and is broken on Windows, which uses LLP64.

Ouch, you are right: https://github.com/arthuredelstein/tor-browser/commit/22415+1

Trac:
Status: needs_revision to needs_review

lgtm

Applied to tor-browser-52.1.1esr-7.0-1 and tor-browser-52.1.0esr-7.0-2 (commit 7aa5a5c8565273ea41a0c003160226f3229373f6 and e404251e7a4e86981a33be035e7fdb0b7ed42c3b), thanks.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#22415 (closed)