Refactor R code to use modern R packages and methods

plot_networksize() has been refactored to use modern R packages & methods, resulting in readable, maintainable code. Details here: http://rpubs.com/johnbwilliams/refactor. Minor adjustments are needed to drop in place. Package dependencecy considerations apply.

Trac:
Username: johnbwilliams

added component::metrics/website owner::metrics-team priority::medium reporter::johnbwilliams resolution::fixed severity::normal status::closed type::enhancement labels

Tweak summary.

Trac:
Summary: plot_networksize() refactor to Refactor plot_networksize() to use modern R packages and methods

I'll pick this up and extend it to all R code we have, after writing more recent R code with help of dplyr and tidyr.

johnbwilliams, if you're still around, maybe you'd like to review the changes?

Trac:
Owner: metrics-team to karsten
Summary: Refactor plot_networksize() to use modern R packages and methods to Refactor R code to use modern R packages and methods
Status: new to accepted

I started making changes and pushing them to master. No need to do the full review process before merging here, it's just presentation. I'll make more changes over the next few days.

I made more changes, but I need to pause for a while and do other stuff now. In the meantime I'm giving this ticket back to the metrics-team pool.

If somebody feels like reviewing some R code, please take a look at the three functions at the end of graphs.R, namely plot_relays_ipv6, plot_bridges_ipv6, and plot_advbw_ipv6: https://gitweb.torproject.org/metrics-web.git/tree/src/main/R/rserver/graphs.R#n1097 ; these would then serve as blueprints for the other graphs.

Trac:
Owner: karsten to metrics-team
Status: accepted to assigned

Grabbing the review to also push #24707 (moved) a little.

Trac:
Owner: metrics-team to iwakeh

Raising priority to high, because I'd like to continue refactoring some more R code in parallel to documenting it for our Sponsor 13 deliverable.

Trac:
Severity: Minor to Normal
Priority: Medium to High

Trac:
Cc: N/A to metrics-team
Keywords: plot_networksize() deleted, N/A added

FWIW, I just pushed two more commits to master.

Assuming the committed code already got tested regarding functionality and calculates the correct results I checked for readability and the like. The modernization makes all much more readable. What hinders here and there is the line breaks and indentation, but that will be work after the style guide is settled (cf. #24707 (moved)).

Also the additional two commits look fine.

Well, it is merged already.

Trac:
Status: assigned to merge_ready

Thanks for looking!

Some functions still use the old code style, so I'd say let's leave this ticket open for now. I'll un-assign it, though, because I'm done for the moment. Feel free to grab it back.

And yes, let's tackle the indentation stuff in #24707 (moved).

Trac:
Owner: iwakeh to metrics-team
Status: merge_ready to assigned

This ticket is about the same priority as most other Metrics/* tickets. Setting priority back to medium.

Trac:
Priority: High to Medium

I think we're using the new code style pretty much everywhere now, or somewhat more precisely, since early 2019. Nothing more to do here. Closing.

Trac:
Resolution: N/A to fixed
Status: assigned to closed

closed