Opened 4 weeks ago

Closed 4 weeks ago

#22424 closed defect (fixed)

Always check for usage underflows in the storage API

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: integer-safety, race-condition
Cc: Actual Points: 0.2
Parent ID: Points: 0.2
Reviewer: Sponsor:


Child Tickets

Change History (2)

comment:1 Changed 4 weeks ago by teor

  • Actual Points set to 0.2
  • Keywords integer-safety race-condition added
  • Status changed from new to needs_review

Please see my branch bug22424, which fixes two different ways the usage could underflow, and does something sensible when it does underflow. (For example, the usage can underflow when we cache the usage, then an external process makes a file bigger, then we delete that file.)

comment:2 Changed 4 weeks ago by nickm

  • Resolution set to fixed
  • Status changed from needs_review to closed

wow, that's an elegantly structured patch series. Merged!

Note: See TracTickets for help on using tickets.