Opened 4 months ago

Closed 4 months ago

#22424 closed defect (fixed)

Always check for usage underflows in the storage API

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version: Tor: 0.3.1.1-alpha
Severity: Normal Keywords: integer-safety, race-condition
Cc: Actual Points: 0.2
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description


Child Tickets

Change History (2)

comment:1 Changed 4 months ago by teor

Actual Points: 0.2
Keywords: integer-safety race-condition added
Status: newneeds_review

Please see my branch bug22424, which fixes two different ways the usage could underflow, and does something sensible when it does underflow. (For example, the usage can underflow when we cache the usage, then an external process makes a file bigger, then we delete that file.)

comment:2 Changed 4 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

wow, that's an elegantly structured patch series. Merged!

Note: See TracTickets for help on using tickets.