Opened 2 years ago

Closed 2 years ago

Last modified 17 months ago

#22430 closed enhancement (fixed)

Add next gen HS support to chutney

Reported by: asn Owned by: teor
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: tor-hs prop224 chutney
Cc: Actual Points:
Parent ID: #22437 Points: 1
Reviewer: teor Sponsor:

Description

We need a networks file and a torrc template for hs-v3 in chutney.

Child Tickets

Attachments (1)

0001-Introduce-hs-v3-network-file-and-temlate.patch (7.4 KB) - added by dgoulet 2 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 2 years ago by asn

Status: newneeds_review

Please see branch bug22430 in https://github.com/asn-the-goblin-slayer/chutney.git.

(I made a chutney repo at: https://github.com/asn-the-goblin-slayer/chutney)

comment:2 Changed 2 years ago by asn

Cc: teor added

comment:3 Changed 2 years ago by cypherpunks

The commit message has a typo (s/temlate/template/).

comment:4 Changed 2 years ago by teor

Status: needs_reviewneeds_revision

Please don't copy and paste configs. Instead, re-use the config in hs.tmpl like this:

${include:hs.tmpl}
HiddenServiceVersion 3

I think we will also want variants with:

  • IPv4 and IPv6 and dual-stack (like hs-only-v6.tmpl and hs-use-v6.tmpl)
  • Exits and no Exits in the network (like hs-min)
  • Single Onion Services and 3-hop Onion Services (like single-onion*.tmpl)

We should do this as part of testing v3 hidden services.

We will also want to add an IPv4 and an IPv6 variant to make test-network-all in tor, see #22437.

comment:5 Changed 2 years ago by teor

Type: defectenhancement

comment:6 Changed 2 years ago by dgoulet

Status: needs_revisionneeds_review

I don't have a chutney repository on tpo for now so here is the format-patch.

comment:7 Changed 2 years ago by teor

Points: 1
Reviewer: teor
Status: needs_reviewneeds_revision

These lines in torrc_templates/hs-v3.tmpl are redundant, because they are already in hs.tmpl:

${include:common.i}
SocksPort 0
Address $ip

I think torrc_templates/single-onion-v3.tmpl can become:

${include:single-onion.tmpl}
${include:hs-v3.tmpl}

Nitpicks:
networks/hs-v3 should have a newline at the end of the file

comment:8 Changed 2 years ago by dgoulet

Status: needs_revisionneeds_review

Fixup commits in ticket22430_01 (yes I do have a chutney repository now!: https://git.torproject.org/user/dgoulet/chutney.git

comment:9 Changed 2 years ago by nickm

Looks okay to me. Let's merge this if you like it, teor.

comment:10 Changed 2 years ago by dgoulet

Status: needs_reviewmerge_ready

comment:11 Changed 2 years ago by teor

Parent ID: #22437

comment:12 Changed 2 years ago by teor

Resolution: fixed
Status: merge_readyclosed

Fixup'd and rebased to master as 2e8ef42.

comment:13 Changed 17 months ago by teor

Cc: teor removed

Remove useless CC

Note: See TracTickets for help on using tickets.