Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22442 closed defect (wontfix)

Blog Search doesn't search in comments

Reported by: cypherpunks Owned by: hiro
Priority: Medium Milestone:
Component: Webpages/Blog Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #22013 Points:
Reviewer: Sponsor:

Description

It gives false sense of searching through the blog, but can't find anything written in comments.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by arma

Is the search thing actually good? That is, sufficiently close to what you'd get from a google search on host:blog.torproject.org?

If not, maybe we should drop it, to reduce surface area, reduce distracting things that people would expect to work when they don't, etc?

comment:2 Changed 3 years ago by hiro

Status: newneeds_review

Search at the moment is searching all the content (comments included). There is a search score that is applied (like a certain keyword needs to be considered relevant in the document. Not sure how much we can tweak this. Therefore I do not really have a comprehensive answer to the question: Is it good? It works if the post has the searched keywords. I think it is nice to have.

comment:3 Changed 3 years ago by cypherpunks

It now has a tab for searching in comments, but search results give links to blogs, not comments.
Also design of the search button is strange (on High).

comment:4 Changed 3 years ago by hiro

Search in drupal is about the blog post. Comments are considered contained in the blog post. Some design features are being fixed on high security mode in tor.

comment:5 Changed 3 years ago by cypherpunks

Search for Users gives links to users, not blogs.
Search for Comments is expected to give permalinks to comments.

comment:6 Changed 3 years ago by hiro

This is because a user is not an object contained in a post.
Search for comments in drupal gives links to blog posts/pages containing the comment.

Last edited 3 years ago by hiro (previous) (diff)

comment:7 Changed 3 years ago by hiro

Resolution: wontfix
Status: needs_reviewclosed

I think it's fine to close this ticket as the search function is working as it is intended. We might decide to remove the search box altogether if we think an external search engine could do that for us.

Note: See TracTickets for help on using tickets.