Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#22443 closed defect (wontfix)

Direct links to comments (old style) no longer work

Reported by: cypherpunks Owned by: hiro
Priority: Medium Milestone:
Component: Webpages/Blog Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #22013 Points:
Reviewer: Sponsor:

Description

Let say open #22153 and see https://blog.torproject.org/blog/tor-browser-70a3-released#comment-263144 in it. The blog will be shown at the beginning. It now wants strange https://blog.torproject.org/comment/263144#comment-263144 permalink to work.

Child Tickets

Change History (13)

comment:1 Changed 4 years ago by cypherpunks

And now developers started to use new permalinks in Trac tickets, e.g. #22457, so both schemes need to be preserved.

comment:2 Changed 4 years ago by dcf

I think it depends on comment pagination, whether the old-style anchor links work. For example, from the ticket description,

https://blog.torproject.org/blog/tor-browser-70a3-released#comment-263144

doesn't work, because it's not on the first page of comments. On the other hand, it works if you link to the next page of comments:

https://blog.torproject.org/blog/tor-browser-70a3-released?page=1#comment-263144

Similarly, direct linking to a different comment, that happens to be on the first page of comments, does work:

https://blog.torproject.org/blog/tor-browser-70a3-released#comment-261646

I believe this was a problem with the old blog too, where anchor links wouldn't work once the comment was pushed off the first page of comments. I'm glad that now we have the /comment/XXXXXX style for more reliable permalinks.

Since the anchor links were slightly broken even in the old blog, I'm not sure anything needs to be done for this ticket. Though a possible workaround would be to make the number of comments per page in the new blog equal to that of the old blog. (Unless threading messes that up.)

comment:4 Changed 3 years ago by hiro

Resolution: fixed
Status: newclosed

Fixed.

comment:5 Changed 3 years ago by cypherpunks

Resolution: fixed
Status: closedreopened

Where?

comment:6 Changed 3 years ago by cypherpunks

I confirm, still not fixed :(

comment:7 Changed 3 years ago by hiro

The anchor works if the comment is on the 1st page. Otherwise the other permalink form to reach the comment has to be used.

comment:8 Changed 3 years ago by hiro

Status: reopenedneeds_review

comment:9 Changed 3 years ago by hiro

Resolution: fixed
Status: needs_reviewclosed

I am going to close this ticket since this is the way the comments also worked in the old blog. We now have a permalink to the comments that works for all pages.

Last edited 3 years ago by hiro (previous) (diff)

comment:10 Changed 3 years ago by cypherpunks

Resolution: fixed
Status: closedreopened

It's sad. But close this ticket properly then.

comment:11 Changed 3 years ago by cypherpunks

Resolution: wontfix
Status: reopenedclosed

comment:12 Changed 3 years ago by cypherpunks

We now have a permalink to the comment that works for all pages.

So could you make a redirection of XXXXX#comment-263144 to https://blog.torproject.org/comment/263144#comment-263144 to fix all problems?

comment:13 Changed 3 years ago by hiro

.htaccess is ignored on pantheon and url redirects within drupal do not support wild cards.

Note: See TracTickets for help on using tickets.