Opened 4 months ago

Closed 4 months ago

#22447 closed defect (fixed)

hs: HSDir do not accept v3 descriptors properly

Reported by: dgoulet Owned by: dgoulet
Priority: Very High Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: 0.3.0.1-alpha
Severity: Normal Keywords: tor-hs, prop224
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: asn Sponsor: SponsorR-can

Description

When a v3 descriptor is uploaded, it goes through a series of validation including encrypted_data_length_is_valid() which checks for the encrypted data size to be a multiple of #define HS_DESC_PLAINTEXT_PADDING_MULTIPLE 128 but it's not true anymore becase we pad up to a minimum of 10000 bytes.

This is currently fixed upstream but wasn't backported to 030. It has been introduced in tor-0.3.0.1-alpha with commit cff1fd63f16.

Child Tickets

Change History (2)

comment:1 Changed 4 months ago by dgoulet

Reviewer: asn
Status: newneeds_review

See branch bug22447_030_01

comment:2 Changed 4 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged to {maint,release}-0.3.0; used an "ours" merge to avoid taking in master.

Note: See TracTickets for help on using tickets.