Opened 23 months ago

#22449 new defect

Remove timestamp_dirty kludge from mark_circuit_unusable_for_new_conns()

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client refactor easy
Cc: Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor:

Description

In mark_circuit_unsusable_for_new_conns(), we set the unusable_for_new_conns flag... but we also carry around some old code that messes around with timestamp_dirty.

The root problem here is that the old code makes timestamp_dirty into a lie; "unusable" and "dirty" are not the same concept.

We should carefully audit timestamp_dirty and its users to make sure that it's safe to remove this old kludge, and then remove it or replace it with something more accurate.

Child Tickets

Change History (0)

Note: See TracTickets for help on using tickets.