favicons in tab drop down list are not first-party isolated

gk noticed that the ESR52-based first-party isolation is not yet working with the tab dropdown list. See #16983 (moved) for our old fix.

added TorBrowserTeam201705R component::applications/tor browser owner::arthuredelstein priority::medium resolution::fixed severity::normal status::closed tbb-7.0-must tbb-linkability type::defect labels

Here's my current fix. It depends on my #22327 (moved) fix which unfortunately as a debug assert right now that I am still trying to track down. But I think this patch is a workable solution.

https://github.com/arthuredelstein/tor-browser/commits/22452

Trac:
Status: new to needs_review
Keywords: tbb-7.0-must TorBrowserTeam201705 deleted, tbb-7.0-must TorBrowserTeam201705R added

(And it is not being reported in browser console by default now, like getFirstPartyFailed by torbutton before.)

Replying to arthuredelstein:

Here's my current fix. It depends on my #22327 (moved) fix which unfortunately as a debug assert right now that I am still trying to track down. But I think this patch is a workable solution.

https://github.com/arthuredelstein/tor-browser/commits/22452

Looks good to me.

Added to tor-browser-52.1.0esr-7.0-2 as commit 1cb4d06b54d26e35c78b398abdd456444b26acd7 and to tor-browser-52.1.1esr-7.0-1 as commit 93469df805f4001dc837299bc3076855d7bff6ae.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Trac:
Keywords: tbb-7.0-must TorBrowserTeam201705R deleted, tbb-7.0-must tbb-first-party TorBrowserTeam201705R added

Trac:
Keywords: tbb-7.0-must tbb-first-party TorBrowserTeam201705R deleted, tbb-7.0-must tbb-lnkability TorBrowserTeam201705R added

Trac:
Keywords: tbb-7.0-must tbb-lnkability TorBrowserTeam201705R deleted, TorBrowserTeam201705R, tbb-7.0-must, tbb-linkability added

closed

moved to tpo/applications/tor-browser#22452 (closed)