Opened 16 months ago

Closed 16 months ago

Last modified 15 months ago

#22452 closed defect (fixed)

favicons in tab drop down list are not first-party isolated

Reported by: arthuredelstein Owned by: arthuredelstein
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-7.0-must, tbb-linkability, TorBrowserTeam201705R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

gk noticed that the ESR52-based first-party isolation is not yet working with the tab dropdown list. See #16983 for our old fix.

Child Tickets

Change History (7)

comment:1 Changed 16 months ago by arthuredelstein

Keywords: TorBrowserTeam201705R added; TorBrowserTeam201705 removed
Status: newneeds_review

Here's my current fix. It depends on my #22327 fix which unfortunately as a debug assert right now that I am still trying to track down. But I think this patch is a workable solution.

https://github.com/arthuredelstein/tor-browser/commits/22452

comment:2 Changed 16 months ago by cypherpunks

(And it is not being reported in browser console by default now, like getFirstPartyFailed by torbutton before.)

comment:3 in reply to:  1 Changed 16 months ago by gk

Replying to arthuredelstein:

Here's my current fix. It depends on my #22327 fix which unfortunately as a debug assert right now that I am still trying to track down. But I think this patch is a workable solution.

https://github.com/arthuredelstein/tor-browser/commits/22452

Looks good to me.

comment:4 Changed 16 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Added to tor-browser-52.1.0esr-7.0-2 as commit 1cb4d06b54d26e35c78b398abdd456444b26acd7 and to tor-browser-52.1.1esr-7.0-1 as commit 93469df805f4001dc837299bc3076855d7bff6ae.

comment:5 Changed 15 months ago by arthuredelstein

Keywords: tbb-first-party added

comment:6 Changed 15 months ago by gk

Keywords: tbb-lnkability added; tbb-first-party removed

comment:7 Changed 15 months ago by cypherpunks

Keywords: tbb-linkability added; tbb-lnkability removed
Note: See TracTickets for help on using tickets.