Adapt our use of the nsIContentPolicy to e10s mode

Finally, after a long back and forth it turns out that we need to adapt our content policy usage to e10s as well.

added GeorgKoppen201705 TorBrowserTeam201706R component::applications/tor browser ff52-esr owner::tbb-team priority::very high resolution::fixed severity::major status::closed tbb-7.0-must tbb-e10s type::defect labels

Trac:
Summary: Adapt our use of the content security policy to e10s mode to Adapt our use of the nsIContentPolicy to e10s mode
Description: Finally, after a long back and forth it turns out that we need to adapt our content security policy to e10s as well.

to

Finally, after a long back and forth it turns out that we need to adapt our content policy usage to e10s as well.
Cc: N/A to mcs, brade, arthuredelstein

Here is a fix for review: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug22459-01&id=4a405563313866d7c76eb03e97de4863e9556bc2

More testing would be appreciated (Kathy and I only tested it on OSX).

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201705 deleted, TorBrowserTeam201705R added

I built the latest tor-browser.git, applied this patch to torbutton.

• First I visited https://arthuredelstein.github.io/tordemos/resource-locale.html. I could see in the web console that it correctly blocked reading the re/ files.
• Then I visited https://mdn.github.io/learning-area/html/multimedia-and-embedding/video-and-audio-content/simple-video.html and found that the video controls are not available and clicking on the video does not cause it to play. Reverting the patch from comment:2 restores the video controls.

So it appears something additional needs to be done to activate the whitelist? As we're on a tight deadline I will continue to investigate.

I wonder if #22104 (moved) is somehow related.

Replying to gk:

I wonder if #22104 (moved) is somehow related.

Might be, I get a similar looking error in the error console:

TypeError: this.scrubberThumb is null  videocontrols.xml:763:21

mcs, some feedback for the patch: it works for me on Linux and Windows. The code looks good to me as well. I noticed you fixed #21627 (moved) in it, too. Could you provide that fix in a separate patch to not mix both issues?

Additionally, regarding what Arthur said: the whitelist gets activated. The problem is that it needs to get updated it seems. (FWIW scrollbars are gone as well).

Moving review tickets to 201706

Trac:
Keywords: TorBrowserTeam201705R deleted, TorBrowserTeam201706R added

Here is a revised patch that removes the #21627 (moved) fix (I forgot about that ticket): https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug22459-02

I will post a separate patch in #21627 (moved).

Kathy and I are working on a revised whitelist; we will post a patch for that in #22104 (moved).

Thanks. Looks good to me. I merged the patch to master with commit 2e301c0a5bbc62fd5f8e66ac973c71f0bc10c81b.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#22459 (closed)