Opened 2 years ago

Closed 2 years ago

#22459 closed defect (fixed)

Adapt our use of the nsIContentPolicy to e10s mode

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: ff52-esr, tbb-e10s, GeorgKoppen201705, tbb-7.0-must, TorBrowserTeam201706R
Cc: mcs, brade, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gk)

Finally, after a long back and forth it turns out that we need to adapt our content policy usage to e10s as well.

Child Tickets

Change History (9)

comment:1 Changed 2 years ago by gk

Cc: mcs brade arthuredelstein added
Description: modified (diff)
Summary: Adapt our use of the content security policy to e10s modeAdapt our use of the nsIContentPolicy to e10s mode

comment:2 Changed 2 years ago by mcs

Keywords: TorBrowserTeam201705R added; TorBrowserTeam201705 removed
Status: newneeds_review

Here is a fix for review:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug22459-01&id=4a405563313866d7c76eb03e97de4863e9556bc2

More testing would be appreciated (Kathy and I only tested it on OSX).

comment:3 Changed 2 years ago by arthuredelstein

I built the latest tor-browser.git, applied this patch to torbutton.

So it appears something additional needs to be done to activate the whitelist? As we're on a tight deadline I will continue to investigate.

comment:4 Changed 2 years ago by gk

I wonder if #22104 is somehow related.

comment:5 in reply to:  4 Changed 2 years ago by gk

Replying to gk:

I wonder if #22104 is somehow related.

Might be, I get a similar looking error in the error console:

TypeError: this.scrubberThumb is null  videocontrols.xml:763:21

comment:6 Changed 2 years ago by gk

mcs, some feedback for the patch: it works for me on Linux and Windows. The code looks good to me as well. I noticed you fixed #21627 in it, too. Could you provide that fix in a separate patch to not mix both issues?

Additionally, regarding what Arthur said: the whitelist gets activated. The problem is that it needs to get updated it seems. (FWIW scrollbars are gone as well).

comment:7 Changed 2 years ago by gk

Keywords: TorBrowserTeam201706R added; TorBrowserTeam201705R removed

Moving review tickets to 201706

comment:8 Changed 2 years ago by mcs

Here is a revised patch that removes the #21627 fix (I forgot about that ticket):
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug22459-02

I will post a separate patch in #21627.

Kathy and I are working on a revised whitelist; we will post a patch for that in #22104.

comment:9 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Looks good to me. I merged the patch to master with commit 2e301c0a5bbc62fd5f8e66ac973c71f0bc10c81b.

Note: See TracTickets for help on using tickets.