In a debug build of Tor Browser, Page Info causes an assert

Stack trace from gk: https://trac.torproject.org/projects/tor/ticket/22327#comment:11

added TorBrowserTeam201706R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-7.0-must type::defect labels

Trac:
Cc: N/A to brade, mcs

My progress so far: I have narrowed the problem down to one of our preferences, set in TB4: Tor Browser's Firefox preference overrides. Working on figuring out which one it is.

The pref that causes a crash with Page Info in a debug build turns out to be "browser.privatebrowsing.autostart". And indeed if I turn that pref off, but after Firefox starts, I open a "New Private Window", then Page Info also hits the assert.

Replying to arthuredelstein:

The pref that causes a crash with Page Info in a debug build turns out to be "browser.privatebrowsing.autostart". And indeed if I turn that pref off, but after Firefox starts, I open a "New Private Window", then Page Info also hits the assert.

Sounds like a Firefox bug to me worth reporting. Could you file a ticket? We might get some workaround/fix we can still squeeze into 7.0.

It looks like such assertions are not rare https://bugzilla.mozilla.org/show_bug.cgi?id=1319908

It turns out this bug was already fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1329521, but unfortunately ESR52 was not patched. Here is my backport for review: https://github.com/arthuredelstein/tor-browser/commit/22462

I tried reproducing the "Browser console" issue also reported in that Mozilla bug but was unable to do so, so I am not backporting the other patch from that bug.

Trac:
Status: new to needs_review
Keywords: tbb-7.0-must TorBrowserTeam201705 deleted, tbb-7.0-must TorBrowserTeam201706R added

r=mcs This looks good to me, and it seems to fix the problem.

Thanks. Applied to tor-browser-52.1.1esr-7.0-1 and tor-browser-52.1.0esr-7.0-2 (commit a63362cbdd952afdeed64c36ba21b6b94aa5d01b and 3f5f0f7d0b7a3384f5b46d2abef6b1bbf631077e).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#22462 (closed)