Opened 2 years ago

Last modified 2 years ago

#22477 new defect

Add -Wl,--large-address-aware to tor-for-Windows build chain

Reported by: tom Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: win32, 032-unreached
Cc: bastik.public@…, tjr, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This linker flag gives a 32 bit application the full 4GB address space, effectively doubling the randomization provided by ASLR and making heap spraying slightly more difficult.

See also:

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by gk

Cc: gk added

comment:2 Changed 2 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.2.x-final

comment:3 Changed 2 years ago by tom

Keywords: win32 added

comment:4 in reply to:  description Changed 2 years ago by cypherpunks

Replying to tom:

This linker flag

It's a compiler flag.

gives a 32 bit application the full 4GB address space,

App always has it, but not always handles it properly.

effectively doubling the randomization provided by ASLR and making heap spraying slightly more difficult.

Things are not so obvious as you think.

It's a bad design, when linker automatically sets it, but doesn't allow to pass it.

tor-for-Windows build chain

Firefox's chain, Tor Browser's chain, TBB's (incl. Expert?) chain, and then that. First chain has it, second - inherits, third - only for Firefox, fourth - not a TBB Team's problem? And this ticket doesn't improve TBB then.
Somebody should synchronize 'em all.

comment:5 Changed 2 years ago by nickm

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Mark a large number of tickets that I do not think we will do for 0.3.2.

Note: See TracTickets for help on using tickets.