Opened 2 years ago

Last modified 22 months ago

#22495 new defect

Partial write in key-pinning-journal results in corrupted line

Reported by: asn Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy, tor-dirauth, 032-unreached
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description (last modified by asn)

Tor sees a corrupted line in its key-pinning-journal because of a truncated line:

@opened-at 2016-08-07 20:49:24
wyD2E2ZG/fDQFbiQbz63VcvSKFo TNh6rQcairXqej0dOoRWOF93Zra+o+x+9b0VbiAG8zI
DahGjy7upvyovkp1sJ1C+/wKmT4 TNh6rQcairXqej0dOoRWOF93Zra+o+x+9b0VbiAG8zI
...
wyD2E2ZG/fDQFbiQbz63VcvSKFo TNh6rQcairXqej0dOoRWOF93Zra+o+x+9b0VbiAG8zI
DahGjy7upvyovkp1sJ1C+/wKmT4 TNh6rQcairXq
@opened-at 2016-10-05 20:02:15
DahGjy7upvyovkp1sJ1C+/wKmT4 TNh6rQcairXqej0dOoRWOF93Zra+o+x+9b0VbiAG8zI

Nick says Tor uses fwrite() when it should be using write() to write to that file.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by asn

Description: modified (diff)

comment:2 Changed 22 months ago by nickm

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Mark a large number of tickets that I do not think we will do for 0.3.2.

Note: See TracTickets for help on using tickets.