Changes between Initial Version and Version 5 of Ticket #22512


Ignore:
Timestamp:
Jun 14, 2017, 2:03:41 PM (2 years ago)
Author:
iwakeh
Comment:

True! I added the new todos to the summary for easier reference.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22512 – Description

    initial v5  
    1 We recently introduced the `Key` enum with keywords contained in relay descriptors, sanitized bridge descriptors, and sanitized bridge pool assignments.  We did not include keywords in exit lists and Torperf measurement results, and in retrospect we should have excluded sanitized bridge pool assignments there.
     1Todo derived from the discussion in comments 1 to 4:
    22
    3 The reason why each data source should have its own enum is that naming conventions might vary in terms of upper/lower case and word separators.  For example, Tor descriptors use `lower-case-keywords`, exit lists contain `CamelCase`, and Torperf/OnionPerf use `ALL_UPPER_CASE_WITH_UNDERSCORES`.  There could be conflicts for keywords like `source` vs. `SOURCE`.
     3Add keywords for all descriptors to `Key` enum.
     4Use a one letter prefix for keywords from non-Tor data sources.
     5First step: determine the best letter for each non-Tor source.
     6
     7
     8Original summary: We recently introduced the `Key` enum with keywords contained in relay descriptors, sanitized bridge descriptors, and sanitized bridge pool assignments.  We did not include keywords in exit lists and Torperf measurement results, ~~and in retrospect we should have excluded sanitized bridge pool assignments there.~~
     9
     10~~The reason why each data source should have its own enum is that naming conventions might vary in terms of upper/lower case and word separators.  For example, Tor descriptors use `lower-case-keywords`, exit lists contain `CamelCase`, and Torperf/OnionPerf use `ALL_UPPER_CASE_WITH_UNDERSCORES`.  There could be conflicts for keywords like `source` vs. `SOURCE`.~~