Opened 2 years ago

Last modified 2 years ago

#22534 new defect

Stop parsing rend protocol versions greater than 7 in legacy hidden service descriptors

Reported by: teor Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.4.3-alpha
Severity: Minor Keywords: hs-legacy spec-conformance maybe-wontfix legacy-hs
Cc: Actual Points:
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description

REND_PROTOCOL_VERSION_BITMASK_WIDTH is 16, but rend_encode_v2_descriptors() only checks bits 0 to 7.

This was introduced in 0a6480c in 0.2.4.3-alpha, which fixed #6827, which was itself a bugfix on c58675 in 0.2.0.10-alpha.

I think we should wontfix this.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by teor

Summary: Stop ignoring rend protocol versions greater than 7 in legacy hidden service descriptorsStop parsing rend protocol versions greater than 7 in legacy hidden service descriptors

This means Tor generates versions 0-7, but parses versions 0-15.

If we do want to fix it, we can make REND_PROTOCOL_VERSION_BITMASK_WIDTH 8, and use it in rend_encode_v2_descriptors(). This will make our parser ignore versions 8-15. And nothing will change.

comment:2 Changed 2 years ago by nickm

Keywords: spec-conformance maybe-wontfix legacy-hs added
Note: See TracTickets for help on using tickets.