Opened 15 months ago

Last modified 3 months ago

#22536 new defect

On New Identity the new window opens at a different location before the old one gets closed

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-7.0-issues, tbb-regression, tbb-newnym, tbb-e10s
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In some circumstances, after hitting New Identity the new browser window will open at a different location on the screen before the old one is gone. We are currently doing:

  OpenBrowserWindow();

  torbutton_log(3, "New identity successful");

  // Run garbage collection and cycle collection after window is gone.
  // This ensures that blob URIs are forgotten.
  window.addEventListener("unload", function (event) {
    torbutton_log(3, "Initiating New Identity GC pass");
    // Clear out potential pending sInterSliceGCTimer:
    m_tb_domWindowUtils.runNextCollectorTimer();

    // Clear out potential pending sICCTimer:
    m_tb_domWindowUtils.runNextCollectorTimer();

    // Schedule a garbage collection in 4000-1000ms...
    m_tb_domWindowUtils.garbageCollect();

    // To ensure the GC runs immediately instead of 4-10s from now, we need
    // to poke it at least 11 times.
    // We need 5 pokes for GC, 1 poke for the interSliceGC, and 5 pokes for CC.
    // See nsJSContext::RunNextCollectorTimer() in
    // https://mxr.mozilla.org/mozilla-central/source/dom/base/nsJSEnvironment.cpp#1970.
    // XXX: We might want to make our own method for immediate full GC...
    for (let poke = 0; poke < 11; poke++) {
       m_tb_domWindowUtils.runNextCollectorTimer();
    }

    // And now, since the GC probably actually ran *after* the CC last time,
    // run the whole thing again.
    m_tb_domWindowUtils.garbageCollect();
    for (let poke = 0; poke < 11; poke++) {
       m_tb_domWindowUtils.runNextCollectorTimer();
    }

    torbutton_log(3, "Completed New Identity GC pass");
  });

  // Close the current window for added safety
  window.close();

So, this issue can show up if the garbage collection takes quite some time for some reason. We might want to think about whether we can improve things for this use case while not making New Identity much slower.

Child Tickets

Change History (3)

comment:1 Changed 15 months ago by gk

Summary: On New Identitythe new window opens at a different location before the old one gets closedOn New Identity the new window opens at a different location before the old one gets closed

comment:2 Changed 7 months ago by cypherpunks

Keywords: tbb-e10s added

It happens only when the child process gets restarted.
To reproduce:
open new tab,
close about:tor,
press new identity.

comment:3 Changed 3 months ago by cypherpunks

The situation with many tabs is much better now with FF60.

Note: See TracTickets for help on using tickets.