pkg-config fails to find static library for zstd

Static build fails to find the libzstd.a library. This is because it uses pkg-config, and zstd's .pc file is missing .private tag. Please see the ticket I submitted: https://github.com/facebook/zstd/issues/719

You probably didn't test the static build with zstd. In any case, static build is broken due to this problem.

changed milestone to %Tor: 0.3.1.x-final

added component::core tor/tor milestone::Tor: 0.3.1.x-final owner::nickm priority::high resolution::not a bug severity::normal status::closed type::defect labels

Trac:
Component: - Select a component to Core Tor/Tor
Milestone: N/A to Tor: 0.3.1.x-final

We have two options for a workaround here:

• try to find the static library without pkg-config
• check at configure time for the library we want to use, and automatically disable zstd if it isn't available (or ask the user to disable zstd)

FreeBSD has disabled both zstd and lzma compression due to this bug. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219864 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219571

Replying to teor:

We have two options for a workaround here:

• try to find the static library without pkg-config
• check at configure time for the library we want to use, and automatically disable zstd if it isn't available (or ask the user to disable zstd)

Another option is to fix .pc and submit a PR to facebook:https://github.com/facebook/zstd/issues/719

FreeBSD has disabled both zstd and lzma compression due to this bug.

I will enable lzma, no worries.

We should make sure to write and upstream such a patch.

Trac:
Priority: Medium to High
Owner: N/A to nickm
Status: new to accepted

It doesn't seem like pkgconfig supports static libraries. Since tor supports static build, pkgconfig appears to be a bad choice.

Why don't you just use AC_SEARCH_LIBS from autotools to search for libraries instead?

It wasn't a problem of pkg-config or Tor. It was a faulty build that somehow produced libzstd.a with stripped symbols.

I will update the FreeBSD port.

Trac:
Status: accepted to closed
Resolution: N/A to not a bug

closed

moved to tpo/core/tor#22550 (closed)