OSX 10.7.5 Auto updated 6.5.1 to incompatible 7

Shouldn't the updater detect that doing so would break the install, forcing the user to uninstall, track down old version and re-install?

Trac:
Username: dehv

added TorBrowserTeam201706 component::applications/tor browser owner::tbb-team priority::high reporter::dehv resolution::fixed severity::normal status::closed tbb-7.0-issues type::defect labels

boklm: Is there something we can do server-side to fix that? IIRC the plan was to update users to 6.5.2 and don't offer further upgrades (which sounds like a good plan to me).

Trac:
Cc: N/A to boklm
Component: - Select a component to Applications/Tor Browser
Owner: N/A to tbb-team

I did some debugging, and it seems like the problem is that the minSupportedOSVersion in the XML update manifest needs to use the Darwin version number instead of the macOS one. For 10.9, we should use 13.0.0. See: https://en.wikipedia.org/wiki/Darwin_(operating_system)#Release_history

Replying to mcs:

I did some debugging, and it seems like the problem is that the minSupportedOSVersion in the XML update manifest needs to use the Darwin version number instead of the macOS one. For 10.9, we should use 13.0.0. See: https://en.wikipedia.org/wiki/Darwin_(operating_system)#Release_history

Really? That's surprising. We had 10.8 for osx32 for years now and did not get a single bug report IIRC.

I just took my old OS X 10.6 out and I still had a 7.0a2 on it. While it showed me a 7.0a4 is available when trying to update I just got a "You can not perform further updates on this system"-message and a windows popped up that my system is unsupported.

The same happened with 6.5.2 on that machine fwiw.

Replying to gk:

I just took my old OS X 10.6 out and I still had a 7.0a2 on it. While it showed me a 7.0a4 is available when trying to update I just got a "You can not perform further updates on this system"-message and a windows popped up that my system is unsupported.

That is because our update manifest has minSupportedOSVersion="10.9" and the Darwin version for 10.6.8 happens to be 10.8. I don't have a macOS 10.7 or 10.8 system to test with, but on a macOS 10.12.5 system osVersion is 16.6.0 after the following statement is executed: let osVersion = Services.sysinfo.getProperty("version");

Ugh, yes, that makes sense. :( I have pushed fixups onto master and maint-7.0 (commit d7a6bc035327a2d92e8b4194e4c89363dede443b and 0f9bbf102c8fc9f137ec00a106e89d439d6e022b (the latter with a slightly better commit message)).

boklm, mcs: please reopen this ticket if they don't make sense. I pushed them directly to get the rebundling going.

Trac:
Resolution: N/A to fixed
Status: new to closed

Trac:
Keywords: N/A deleted, TorBrowserTeam201706 added
Cc: boklm to boklm, mcs

Trac:
Keywords: N/A deleted, tbb-7.0-issues added

I applied the fix manually to the 7.0 update manifests on aus1.tpo.

FWIW: I pushed two follow-up commits to make this whole business less error-prone/fix an error in the previous commit (on master commit 36808fe250f4c1de115fc200e1eb9294cbcdc2c0 and on maint-7.0 commit 23de6c6eaec91d4acfad764072dde2b6e58b0c6e).

closed

moved to tpo/applications/tor-browser#22558 (closed)