Opened 3 years ago

Closed 3 years ago

#22560 closed defect (fixed)

Update privacy.thirdparty.isolate preference in Torbutton

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-7.0-issues, tbb-regression, TorBrowserTeam201706R
Cc: mcs, brade, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


privacy.thirdparty.isolate is gone with the switch to ESR52, yet we still try to use it in Torbutton. We should get rid of the preferences in torbutton_update_thirdparty_prefs() that we don't need anymore and adapt privacy.thirdparty.isolate for the remaining ones (it is privacy.firstparty.isolate now).

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by gk

Keywords: tbb-regression TorBrowserTeam201706R added
Status: newneeds_review

comment:2 Changed 3 years ago by mcs

r=brade, r=mcs
This looks good to us, although it would be good for Arthur to also review it.
One small suggestion: rename the torbutton_update_thirdparty_prefs() function to torbutton_update_isolation_prefs().

comment:3 Changed 3 years ago by arthuredelstein

Looks good to me as well. I'd also suggest changing the var block_thirdparty to firstparty_isolate or something similar.

comment:4 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks for the reviews I followed both suggestions and pushed the resulting fix to master (commit b917b2024bb71b2be832439df793ae5ec91d8082).

Note: See TracTickets for help on using tickets.