Opened 2 years ago

Last modified 5 months ago

#22598 needs_information defect

When updater read fails, About Tor Browser and Quit stop working

Reported by: teor Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-update
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I was running Tor Browser 7.0 on macOS 10.12.

When it tried to update to 7.0.1, org.mozilla.updater[0] temporarily failed to read ~/Library/Application Support/TorBrowser-Data/ due to some security settings I have.

When this happened, Tor Browser's "About Tor Browser" and "Quit" menu items stopped working. When I force quit and relaunched Tor Browser, the update worked well, and everything now works fine.

But we really shouldn't make the app impossible to quit (or impossible to re-try an update) just because the data directory is read-only.

[0]: /Users/USER/Library/Application Support/TorBrowser-Data/UpdateInfo/Applications/TorBrowser/updates/0/updater.app/Contents/MacOS/org.mozilla.updater

Child Tickets

Change History (4)

comment:1 Changed 2 years ago by mcs

Status: newneeds_information

We don't do too much to change the way the updater works in terms of processes and file access, so this is likely a Firefox bug. How can I reproduce it? Do you have special software that prevents new binaries from accessing files? Or is this something I can reproduce use macOS settings?

comment:2 in reply to:  1 Changed 8 months ago by teor

Replying to mcs:

We don't do too much to change the way the updater works in terms of processes and file access, so this is likely a Firefox bug. How can I reproduce it? Do you have special software that prevents new binaries from accessing files? Or is this something I can reproduce use macOS settings?

Here are three possible ways to reproduce issues like this:

  1. use FSecure XFence (used to be called Little Flocker) to deny access to files
  2. install Tor Browser as an admin user, but open it as a non-admin user
  3. do 2, but also turn on macOS parental controls, and allow Tor Browser
  4. do 2, but also turn on macOS parental controls, and don't allow Tor Browser

You will get a range of interesting errors.

comment:3 Changed 5 months ago by gk

Keywords: tbb-updater added

comment:4 Changed 5 months ago by gk

Keywords: tbb-update added; tbb-updater removed

Renaming keyword to make it a bit broader

Note: See TracTickets for help on using tickets.