Opened 4 months ago

Closed 8 weeks ago

#22610 closed defect (fixed)

Tor Browser 7 crashes when cancelling downloads on the external helper app warning

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-crash, tbb-7.0-issues, tbb-regression, tbb-e10s
Cc: mcs, brade, tilman Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor Browser 7.5a1 (7.0.1 doesn't have this issue as far as I tested)

Platform: Debian sid 64 bits.

Steps to reproduce:

  1. Open Tor Browser,
  2. Ctrl+O
  3. Select some PDF file and click open
  4. Download box will show up, click on cancel
  5. it should crash

When debugging:

[Parent 3674] ###!!! ABORT: __delete__()d actor: file /home/debian/build/tor-browser/ipc/glue/ProtocolUtils.cpp, line 299
[Parent 3674] ###!!! ABORT: __delete__()d actor: file /home/debian/build/tor-browser/ipc/glue/ProtocolUtils.cpp, line 299
Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=8.69987) [GFX1-]: Receive IPC close with reason=AbnormalShutdown
[Child 3795] WARNING: pipe error (3): Connection reset by peer: file /home/debian/build/tor-browser/ipc/chromium/src/chrome/common/ipc_channel_posix.cc, line 322
[Child 3795] ###!!! ABORT: Aborting on channel error.: file /home/debian/build/tor-browser/ipc/glue/MessageChannel.cpp, line 2152
[Child 3795] ###!!! ABORT: Aborting on channel error.: file /home/debian/build/tor-browser/ipc/glue/MessageChannel.cpp, line 2152
[notice] Owning controller connection has closed -- exiting now.
[notice] Catching signal TERM, exiting cleanly.
./Browser/start-tor-browser: line 369:  3674 Segmentation fault      (core dumped) TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --class "Tor Browser" -profile TorBrowser/Data/Browser/profile.default "${@}" < /dev/null

Child Tickets

Change History (14)

comment:1 Changed 4 months ago by gk

Priority: MediumHigh
Severity: NormalMajor
Status: newneeds_information

Hm, there is no download box showing up for me. The document loads directly in the pdf viewer. Do you have a particular file causing this (maybe one I could download and then load from the desktop)?

Note as well, the alpha and the stable are basically identical at this time apart from a Windows related patch being in the alpha series but not the stable one. So, that issue should happen on stable as well...

comment:2 in reply to:  1 Changed 4 months ago by cypherpunks

Replying to gk:

Hm, there is no download box showing up for me. The document loads directly in the pdf viewer. Do you have a particular file causing this (maybe one I could download and then load from the desktop)?

I could no longer reproduce the issue when I re-installed the Tor Browser, which is strange considering that I had already gpg authenticated (as I always do) the previous installation on which this problem occurred.

Also note that it happened with ALL pdf files that I tried, not just a particular one. Furthermore, when normally loading pdfs from a site it would show up in pdf.js, but when I tested it started showing me the download box instead.

comment:3 Changed 4 months ago by cypherpunks

Ok, found a way to replicate the issue, if you set pdfjs.disabled to true and repeat the steps in the OP you get it to crash. (Not however that I didn't modify this pref when I first encountered this problem, it was a standard install of the Tor Browser and for some reason pdfjs didn't work as I explained in #comment2)

Haven't tested on 7.0.1 but it may likely be affected as well.

comment:4 Changed 4 months ago by cypherpunks

Status: needs_informationnew

comment:5 in reply to:  3 Changed 4 months ago by gk

Cc: mcs brade added
Keywords: tbb-7.0-issues tbb-regression tbb-e10s added
Priority: HighMedium
Severity: MajorNormal

Replying to cypherpunks:

Ok, found a way to replicate the issue, if you set pdfjs.disabled to true and repeat the steps in the OP you get it to crash. (Not however that I didn't modify this pref when I first encountered this problem, it was a standard install of the Tor Browser and for some reason pdfjs didn't work as I explained in #comment2)

Haven't tested on 7.0.1 but it may likely be affected as well.

Yeah, I just found out the same: Going to about:preferences#applications and setting the pdf option to "Always ask" AND being in e10s mode reproduces the issue for me.

Now, not sure what disabled your pdf viewer, though. The standard install comes with it enabled and we did not change that over the years.

comment:6 Changed 4 months ago by gk

Summary: Tor Browser 7.5a1 crashes when opening a PDF file on my desktopTor Browser 7 crashes when opening a PDF file on my desktop not using the pdf viewer

comment:7 Changed 4 months ago by mcs

Does this problem disappear if the external helper app warning is disabled (extensions.torbutton.launch_warning = false)?

comment:8 in reply to:  7 Changed 4 months ago by gk

Replying to mcs:

Does this problem disappear if the external helper app warning is disabled (extensions.torbutton.launch_warning = false)?

Yes. The crash happens only if one clicks on Cancel on the external helper app dialog.

comment:9 Changed 4 months ago by gk

Cc: tilman added

#22658 shows how one can reproduce the problem in default settings (without disabling pdfjs).

comment:10 Changed 4 months ago by gk

Summary: Tor Browser 7 crashes when opening a PDF file on my desktop not using the pdf viewerTor Browser 7 crashes when opening a PDF file on my desktop and cancelling (the download)

comment:11 in reply to:  9 Changed 3 months ago by cypherpunks

Replying to gk:

#22658 shows how one can reproduce the problem in default settings (without disabling pdfjs).

Also issue doesn't happen with just pdfjs but also when opening any files that the Tor Browser can't read and then clicking on Cancel in the external helper app. Tested on Windows 7 as well.

comment:12 Changed 3 months ago by cypherpunks

Summary: Tor Browser 7 crashes when opening a PDF file on my desktop and cancelling (the download)Tor Browser 7 crashes when cancelling downloads on the external helper app warning

comment:13 Changed 3 months ago by mcs

I resolved #22999 as a duplicate.

comment:14 Changed 8 weeks ago by gk

Resolution: fixed
Status: newclosed

Fixed by the patches in #22618.

Note: See TracTickets for help on using tickets.