Opened 11 months ago

Closed 3 months ago

Last modified 12 days ago

#22614 closed defect (fixed)

Make e10s/non-e10s Tor Browsers indistinguishable

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, tbb-fingerprinting, TorBrowserTeam201802R, tbb-no-uplift, ff60-esr-will-have, tbb-backported
Cc: dmr Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Just citing gk:

e10s in its current form probably brings some fingerprinting risks with it. e.g. users of accessibility tools won't have e10s enabled on Windows and macOS at least. Windows XP users with D3D9 support neither. mcs and brade found that showModalDialog() is not available when e10s is enabled etc.

Child Tickets

Attachments (1)

0001-Bug22614-Make-e10s-non-e10s-Tor-Browsers-indistingui.patch (1.3 KB) - added by ffmancera 4 months ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 11 months ago by cypherpunks

users of accessibility tools

not only those users, but

Also, on a Microsoft Surface Pro / Windows 10 that with a11y enabled: <Multiprocess Windows 0/1 Dissabled by accesibility tools>.

https://bugzilla.mozilla.org/show_bug.cgi?id=1329752#c26
a11y enabled by default on all touch screens.

Last edited 9 months ago by cypherpunks (previous) (diff)

comment:2 Changed 9 months ago by cypherpunks

Backport removal of window.showModalDialog https://bugzilla.mozilla.org/show_bug.cgi?id=981796

comment:3 Changed 8 months ago by cypherpunks

Status: newneeds_review

Set dom.disable_window_showModalDialog to true to fix the obvious part of this ticket without patching.

comment:4 in reply to:  3 Changed 8 months ago by gk

Status: needs_reviewneeds_information

Replying to cypherpunks:

Set dom.disable_window_showModalDialog to true to fix the obvious part of this ticket without patching.

But that prevents the parent process from using that feature as well, right? Do we have some estimate about what that would break? (We'd need a patch for actual review)

comment:5 Changed 8 months ago by cypherpunks

Status: needs_informationnew

It is for non-e10s only. As you see it is already disabled in e10s and removed in upstream. Some legacy things would break in non-e10s, but that's not what we should take care of. (So you want the backported patch to remove it completely, but it looks better to keep the pref, if somebody would complain.)

comment:6 Changed 4 months ago by ffmancera

Status: newneeds_review

Here is a patch! I hope everything is fine.

comment:7 Changed 4 months ago by gk

Keywords: TorBrowserTeam201802R added

comment:8 Changed 3 months ago by mcs

r=mcs
The patch looks good to me and it seems to work. I tested it on macOS and, with or without e10s enabled, calling window.showModalDialog() generates a TypeError: window.showModalDialog is not a function exception.

comment:9 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks for testing, mcs. Applied to tor-browser-52.6.0esr-8.0-2 (commit a91cf5fa9be89c32948f72b87819ff08c43a360e).

comment:10 Changed 3 months ago by arthuredelstein

mcs mentioned this fix will no longer be needed in TBB/ESR60 because of the patches landed in https://bugzilla.mozilla.org/show_bug.cgi?id=981796

comment:11 Changed 3 months ago by arthuredelstein

Keywords: tbb-no-uplift added

comment:12 Changed 3 months ago by arthuredelstein

Keywords: ff60-esr-obsolete added

comment:13 in reply to:  10 ; Changed 3 months ago by cypherpunks

This ticket was filed to investigate the differences between modes, but closed as fixed without mentioning the results of it. What was found during RFP project?

Replying to arthuredelstein:

mcs mentioned this fix will no longer be needed in TBB/ESR60 because of the patches landed in https://bugzilla.mozilla.org/show_bug.cgi?id=981796

Not comment:2?
Does upstream team agree with your ff60-esr-obsolete or can prove ff60-esr-will-have?

comment:14 Changed 3 months ago by gk

Keywords: ff60-esr-will-have tbb-backport added; ff60-esr-obsolete removed

comment:15 Changed 3 weeks ago by gk

Keywords: tbb-backported added; tbb-backport removed

Backported to tor-browser-52.8.0esr-7.5-1 (commit deaa82b4f8ab411198ca300f614df3970221455e). Should be available in 7.5.4.

comment:16 in reply to:  13 Changed 3 weeks ago by gk

Replying to cypherpunks:

This ticket was filed to investigate the differences between modes, but closed as fixed without mentioning the results of it. What was found during RFP project?

Replying to arthuredelstein:

mcs mentioned this fix will no longer be needed in TBB/ESR60 because of the patches landed in https://bugzilla.mozilla.org/show_bug.cgi?id=981796

Not comment:2?
Does upstream team agree with your ff60-esr-obsolete or can prove ff60-esr-will-have?

I think ESR60 is different enough that we could think about filing a new ticket thinking about the remaining things to do wrt to e10s/non-e10s fingerprintability, if there are any left at all.

comment:17 Changed 12 days ago by dmr

Cc: dmr added

For anyone else who might land here wondering what "e10s" is:
It's short for "Electrolysis", which is Firefox's multi-process architecture work.

Not to be confused with Electrolysis, the process by which electricity is applied to e.g. separate elements.

Note: See TracTickets for help on using tickets.