#22629 closed defect (fixed)

tor_compress_impl() ignores trailing input garbage when decompressing

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version: Tor: 0.3.1.1-alpha
Severity: Normal Keywords:
Cc: ahf Actual Points:
Parent ID: #22502 Points: 0.2
Reviewer: Sponsor: Sponsor4

Description

In case TOR_COMPRESS_OK:, it will happily report success when in_len is non-zero.

Child Tickets

Change History (8)

comment:1 Changed 16 months ago by nickm

Owner: set to ahf
Status: newassigned

comment:2 Changed 16 months ago by teor

There is a fix for this in the branch in #22502, but I'd like someone to review it.

comment:3 Changed 15 months ago by nickm

Owner: changed from ahf to nickm
Status: assignedaccepted

Merged as part of #22502, but the fix didn't correctly handle multiple concatenated objects. I've added a new test and fix in my branch bug22629_redux_031.

comment:4 Changed 15 months ago by nickm

Status: acceptedneeds_review

comment:5 Changed 15 months ago by nickm

This is now also a part of my bug22502_redux_031 branch.

comment:6 Changed 15 months ago by ahf

Status: needs_reviewmerge_ready

Looks good to me.

comment:7 Changed 15 months ago by nickm

Sponsor: Sponsor4

comment:8 Changed 15 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged

Note: See TracTickets for help on using tickets.